fix(asyncgit): log diff/blame notification channel errors#2950
Open
leno23 wants to merge 1 commit into
Open
Conversation
Avoid panicking when the UI channel is closed while async diff or blame workers finish, matching the status worker pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.expect("error sending diff")and.expect("error sending blame")with error logging when the async notification channel is unavailable (e.g. UI shutting down).Test plan
cargo check -p asyncgitRelated to #2713 (same panic-avoidance pattern in async workers).
Made with Cursor