feat(status): debounce arrow-key edge navigation (#2898)#2939
Open
leno23 wants to merge 1 commit into
Open
Conversation
Add KeyRepeatGuard so panel switches at scroll edges only fire if the same arrow key was idle for 500ms, reducing accidental jumps from autorepeat. Applies to status tab focus changes and diff horizontal exit. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the debounce approach from #2898 for the status tab and full-screen diff:
KeyRepeatGuardrecords arrow key presses and blocks edge navigation (switching panels / leaving diff) if the same key was pressed within the last 500ms.move_down/move_up) and leaving diff viamove_leftat horizontal scroll edge.move_leftreturnsNotConsumedwhen horizontal scroll cannot move further, so status can handle exit with the guard.Autorepeat scrolling no longer accidentally jumps panels; press the arrow key again after a brief pause to switch intentionally.
Closes #2898 (partial — commit message textarea and other scrollable popups can follow in a follow-up).
Test plan
cargo test -p gitui key_repeat_guardDownat bottom of WorkDir list — should not jump to Stage until key released and pressed againLeftin diff at left edge — should not unfocus diff until key released and pressed againMade with Cursor