fix: AltGr commit input (Windows) and clearer repo open errors#2936
Open
leno23 wants to merge 1 commit into
Open
fix: AltGr commit input (Windows) and clearer repo open errors#2936leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Treat Ctrl+Alt character input as text on Windows so AltGr layouts (e.g. German braces) work in the commit message field (gitui-org#2848). Improve repository open error messages for discovery/not-found failures instead of misleading bare-repo wording (gitui-org#2866). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Alt. The commit messageTextInputpreviously ignored anyCharevent with modifiers, so German layout characters like{}[]could not be typed.is_text_char_inputnow acceptsCtrl+Altas text input on Windows while still rejecting loneCtrlshortcuts.repo_open_errornow maps common discovery / not-found failures to a clearer message (path, underlying error, sandboxing hint) instead of surfacing misleading bare-repo wording from lower layers.Test plan
cargo test -p asyncgit format_repo_open_error_not_foundcargo test -p gitui test_is_text_char_input_without_modifiers{}in message fieldFixes #2848
Fixes #2866
Made with Cursor