refactor(notifications): generate notification URL via the adapter#2886
Open
afonsojramos wants to merge 1 commit into
Open
refactor(notifications): generate notification URL via the adapter#2886afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
|
setchy
requested changes
May 12, 2026
Member
setchy
left a comment
There was a problem hiding this comment.
Octokit client has inbuilt caching the typing. I wouldn't want to stray from that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Follow-up to #2874.
notifications/url.tsimportedgetHtmlUrldirectly fromforges/github/clientand called it for every notification — including ones from Gitea accounts. That was a sharp adapter leak.getHtmlUrlimport withadapter.followUrl<{ html_url: string }>(account, url). The Gitea adapter already implementsfollowUrl(viagiteaGetJson), so this works for both forges.generateGitHubWebUrl→generateNotificationWebUrlto match what it actually does.getHtmlUrlhelper fromforges/github/client.tsplus its test, and theGitHubHtmlUrlResponsetype.githubAdapter.followUrlinstead of the deleted helper.Test plan
pnpm exec tsc --noEmit— cleanpnpm lint— cleanpnpm exec vitest --run src/renderer/utils/notifications/url.test.ts src/renderer/utils/forges/github/client.test.ts src/renderer/utils/system/links.test.ts src/renderer/utils/system/native.test.ts— passes