Keep debug buttons inside one-line chat messages - #249
Merged
MaggieAppleton merged 1 commit intoOct 3, 2026
Merged
Conversation
MaggieAppleton
force-pushed
the
maggie/jev-010-debug-height
branch
from
October 3, 2026 06:10
12b8032 to
cdfdaa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the inline chat pills leaves a one-line message 24px tall, but its visible debug button is 28px tall. Reserve 28px of message height when a diagnostics control exists so the button remains inside its message.
This follows the combined behavior of #243 and #245. The image shows the actual rendered Chat component; outlines mark measured message and button bounds.
Validation: the unchanged native containment test reproduced the 4px overflow before this patch and passes afterward at both narrow and desktop widths. All 26 affected native tests pass in the combined candidate. Independent source review approved the four-line CSS change; formatting and repository CI pass on this branch.