Skip to content

Widen the default Chat pane by 60px #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaggieAppleton merged 3 commits into from
Oct 3, 2026
Merged

Widen the default Chat pane by 60px #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce4b59d
Widen the default chat pane by 60px
MaggieAppleton Oct 2, 2026
a6f7f1d
Record JEV-006 PR and verified width comparison
MaggieAppleton Oct 2, 2026
75836b5
Remove planning artifacts and streamline regression coverage
MaggieAppleton Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import type {
export type Pane = "chat";

const CHAT_PANE = {
initial: 304,
initial: 364,
max: 400,
min: 304,
storageKey: "chopin:pane:chat",
Expand Down
9 changes: 5 additions & 4 deletions e2e/conversation-plan-layout.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ function chatPane(page: Page) {
return page.getByRole("complementary", { includeHidden: true, name: "Chat" });
}

test("desktop Chat sits before the document at its initial 304px width", async ({ join, page }) => {
test("desktop Chat retains its width and stays beside the document as the window grows", async ({ join, page }) => {
await page.setViewportSize({ width: 1280, height: 800 });
await join("ana");
let chat = chatPane(page);
let document = page.locator("main");
let initialWidth = (await box(chat)).width;

for (let width of [1280, 1440]) {
await page.setViewportSize({ width, height: 800 });
await expect.poll(async () => (await box(chat)).width).toBeCloseTo(304, 0);
await expect.poll(async () => (await box(chat)).width).toBeCloseTo(initialWidth, 0);
let [chatBox, documentBox, frameBox] = await Promise.all([
box(chat),
box(document),
Expand Down Expand Up @@ -47,11 +48,11 @@ test("the Chat edge grows right, keeps its left-side reopen control, and remembe

await page.mouse.move(dragX, dragY);
await page.mouse.down();
await page.mouse.move(dragX + 40, dragY, {
await page.mouse.move(dragX + 20, dragY, {
steps: 4,
});
await page.mouse.up();
await expect.poll(async () => (await box(chat)).width).toBeGreaterThan(initial.width + 30);
await expect.poll(async () => (await box(chat)).width).toBeGreaterThan(initial.width + 10);
expect((await box(chat)).x).toBeCloseTo(initial.x, 0);
let pointerWidth = (await box(chat)).width;

Expand Down
4 changes: 2 additions & 2 deletions scripts/design-contract/exceptions/dynamic-web.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
1
]
],
"sourceHash": "5f41df3a09f1671ac41a3b0b70cd4416efecbcc76e7ed4a45d16b49b7e29c49d"
"sourceHash": "7b07be5a575fd36ebaac2f95b3f08258126e1efb2a2b3c48790502e63d382f7f"
},
{
"file": "apps/web/src/workspace.tsx",
Expand Down Expand Up @@ -249,7 +249,7 @@
2
]
],
"sourceHash": "5f41df3a09f1671ac41a3b0b70cd4416efecbcc76e7ed4a45d16b49b7e29c49d"
"sourceHash": "7b07be5a575fd36ebaac2f95b3f08258126e1efb2a2b3c48790502e63d382f7f"
},
{
"file": "apps/web/src/navigation-dialog.tsx",
Expand Down
Loading