-
Notifications
You must be signed in to change notification settings - Fork 187
Add micro tense phrasing #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxbeizer
wants to merge
2
commits into
mb/micro-explicit-threshold
Choose a base branch
from
mb/micro-tense-phrasing
base: mb/micro-explicit-threshold
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−57
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,22 +236,37 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor | |
| return 'datetime' | ||
| } | ||
|
|
||
| #getMicroDuration(duration: Duration): Duration { | ||
| duration = roundToSingleUnit(duration) | ||
| // Allow month-level durations to pass through even with mismatched tense | ||
| if ( | ||
| duration.months === 0 && | ||
| ((this.tense === 'past' && duration.sign !== -1) || (this.tense === 'future' && duration.sign !== 1)) | ||
| ) { | ||
| return microEmptyDuration | ||
| } | ||
| return duration | ||
| } | ||
|
|
||
| #getMicroRelativeFormat(duration: Duration): string { | ||
| const relativeFormat = new Intl.RelativeTimeFormat(this.#lang, { | ||
| numeric: 'always', | ||
| style: 'narrow', | ||
| }) | ||
| duration = this.#getMicroDuration(duration) | ||
| const [int, unit] = getRelativeTimeUnit(duration.blank ? microEmptyDuration : duration) | ||
| return relativeFormat.format(Math.abs(int) * (this.tense === 'past' ? -1 : 1), unit) | ||
| } | ||
|
|
||
| #getDurationFormat(duration: Duration): string { | ||
| const locale = this.#lang | ||
| const format = this.format | ||
| const style = this.formatStyle | ||
| const tense = this.tense | ||
| let empty = emptyDuration | ||
| if (format === 'micro') { | ||
| duration = roundToSingleUnit(duration) | ||
| duration = this.#getMicroDuration(duration) | ||
| empty = microEmptyDuration | ||
| // Allow month-level durations to pass through even with mismatched tense | ||
| if ( | ||
| duration.months === 0 && | ||
| ((this.tense === 'past' && duration.sign !== -1) || (this.tense === 'future' && duration.sign !== 1)) | ||
| ) { | ||
| duration = microEmptyDuration | ||
| } | ||
| } else if ((tense === 'past' && duration.sign !== -1) || (tense === 'future' && duration.sign !== 1)) { | ||
| duration = empty | ||
| } | ||
|
|
@@ -624,7 +639,11 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor | |
| newText = this.#getUserPreferredAbsoluteTimeFormat(date) | ||
| } else { | ||
| if (format === 'duration') { | ||
| newText = this.#getDurationFormat(duration) | ||
| if (this.format === 'micro' && this.tense !== 'auto' && Intl.RelativeTimeFormat) { | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The tense phrasing is intentionally limited to micro duration output. Datetime fallback from #354 and user-preferred absolute output bypass this path, so we do not produce strings like |
||
| newText = this.#getMicroRelativeFormat(duration) | ||
| } else { | ||
| newText = this.#getDurationFormat(duration) | ||
| } | ||
| } else if (format === 'relative') { | ||
| newText = this.#getRelativeFormat(duration) | ||
| } else { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses
Intl.RelativeTimeFormatrather than string-concatenating Englishago/in, so the compact tense output still followslang.