docs: clarify path filters for changes to git submodule files - #45766
sushant-me wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
Thanks for submitting a PR, @sushant-me — we'll consider this in the context of the original issue, but since that wasn't approved for user contributions I'm unable to review this at this time. I'm happy to leave this open, but I'd also note that the original contributor may prefer to raise their own PR in the event that a contribution's approved. Thank you |
|
Thanks @subatoi — that is a clear answer, and I appreciate you taking the time to give it rather than leaving it hanging. I will leave this open, since you said you are happy to. If it is ever cleaner to close it, or to have the original contributor carry the change themselves, just say so and I will do either straight away — the edit is small and self-contained, so porting it across is cheap and nothing here is worth holding up. Thanks again for the clear process answer. |
Closes #44228. Adds a note to \on.<push|pull_request|pull_request_target>.<paths|paths-ignore>\ clarifying that to detect changes to files inside a git submodule, you should filter on the path to the top-level submodule rather than paths within the submodule.