Skip to content

Clean up codeql.resolveLanguages#3954

Merged
henrymercer merged 2 commits into
mainfrom
henrymercer/tidy-resolve-languages
Jun 5, 2026
Merged

Clean up codeql.resolveLanguages#3954
henrymercer merged 2 commits into
mainfrom
henrymercer/tidy-resolve-languages

Conversation

@henrymercer
Copy link
Copy Markdown
Contributor

Only the betterjson option is now used, so remove the old version.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Only the betterjson option is now used, so remove the old version.
@henrymercer henrymercer requested a review from a team as a code owner June 5, 2026 11:51
Copilot AI review requested due to automatic review settings June 5, 2026 11:51
@github-actions github-actions Bot added the size/S Should be easy to review label Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the CodeQL CLI language-resolution API by removing the legacy betterResolveLanguages method and standardizing on a single resolveLanguages implementation that uses the --format=betterjson output.

Changes:

  • Replace all call sites of betterResolveLanguages() with resolveLanguages().
  • Update stubs/mocks in unit tests to align with the new resolveLanguages method name and output expectations.
  • Simplify the CodeQL interface by removing the old JSON-format resolveLanguages variant and keeping only the betterjson-based behavior.
Show a summary per file
File Description
src/workflow.ts Switch language alias resolution to call codeql.resolveLanguages().
src/workflow.test.ts Update stubbing to match the renamed resolveLanguages() API.
src/trap-caching.ts Use resolveLanguages() to query extractor metadata for TRAP caching support.
src/trap-caching.test.ts Update stubbed CodeQL implementation to provide resolveLanguages().
src/config-utils.ts Use resolveLanguages({ filterToLanguagesWithQueries }) for supported language detection.
src/config-utils.test.ts Update stub implementations and expectations for resolveLanguages() output.
src/codeql.ts Remove the old JSON resolveLanguages method and rename betterjson variant to resolveLanguages.
lib/entry-points.js Generated output updated to reflect the TypeScript changes (not reviewed).

Copilot's findings

  • Files reviewed: 7/8 changed files
  • Comments generated: 1

Comment thread src/codeql.ts
@henrymercer henrymercer added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit e263f3a Jun 5, 2026
225 checks passed
@henrymercer henrymercer deleted the henrymercer/tidy-resolve-languages branch June 5, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants