Skip to content

refactor(runner-providers): isolate EC2 provider handling - #5254

Open
edersonbrilhante wants to merge 2 commits into
experimental-multi-runner-config-v2-20260805from
refactor-ec2-provider-isolation
Open

refactor(runner-providers): isolate EC2 provider handling#5254
edersonbrilhante wants to merge 2 commits into
experimental-multi-runner-config-v2-20260805from
refactor-ec2-provider-isolation

Conversation

@edersonbrilhante

Copy link
Copy Markdown
Contributor

Description

Moves dynamic-label provider selection out of the webhook Lambda and into the runner-provider package so Lambda orchestration depends only on a generic provider boundary.

  • Moves selector ownership and routing tests into libs/runner-providers.
  • Makes webhook dispatch tests mock the generic selector instead of exercising EC2 policy behavior.
  • Moves EC2 dynamic-label behavior coverage into the EC2 provider tests.
  • Extracts reusable AWS dynamic-label policy evaluation while preserving the EC2 policy interface.
  • Uses a stable fake provider name in unsupported-provider tests.
  • Removes the unused webhook policy type facade.

This is stacked on #5251 and prepares the provider boundary for additional runner implementations without adding a new provider.

Test Plan

  • Runner-provider suite: 48 files and 794 tests passed.
  • Webhook dispatch suite: 16 tests passed.
  • Focused control-plane suites: 125 tests passed.
  • ESLint passed for the modified provider and Lambda files.
  • Production TypeScript check passed.
  • Webhook and control-plane Lambda builds passed.

Related Issues

Depends on #5251.

Related to #5252.

@edersonbrilhante
edersonbrilhante marked this pull request as ready for review August 7, 2026 20:54
@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner August 7, 2026 20:54
@edersonbrilhante
edersonbrilhante force-pushed the refactor-ec2-provider-isolation branch from 1fc78c4 to b948b89 Compare August 7, 2026 21:42
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant