test: align runner tests with provider modules - #5232
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
refactor-ec2-test-layout
branch
from
July 30, 2026 21:54
a09c4e6 to
9045340
Compare
guicaulada
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align test-file ownership with the runner-provider module layout introduced in #5203 and requested in #5230.
This PR only renames or relocates existing tests. Provider-neutral tests remain beside the shared orchestration modules, while EC2-specific tests move beside their EC2 implementations.
I plan to create following PR to reduced some duplicated tests. I didn't change in this PR to prevent a hard review
Test cases moved or renamed
control-plane/src/aws/runners.test.tstoec2-runners.test.ts.webhook/src/runners/dynamic-labels-policy.test.tstoec2-dynamic-labels-policy.test.ts.canRunJobtest declarations fromdispatch.test.tstolabels.test.ts.dispatch.test.tstoaws-dynamic-labels.test.ts.dispatch.test.tstoec2-dynamic-labels.test.ts; 18 dispatch integration tests remain indispatch.test.ts.pool.test.tstoec2-pool.test.ts; 17 provider-neutral pool tests remain inpool.test.ts.scale-down.test.tstoec2-scale-down.test.ts; four provider-neutral eviction-order tests remain inscale-down.test.ts.scale-up.test.tstoec2-scale-up.test.ts; the provider-selection test remains inscale-up.test.ts.Test cases created
None.
Duplicated test cases merged
None.
Test cases deleted
None. The test titles and coverage from
origin/mainare preserved.Test Plan
git diff --checkpassed.Related Issues
Closes #5230