fix(github): Ungate inbound issue status sync from removed feature flag#119079
Open
souredoutlook wants to merge 1 commit into
Open
fix(github): Ungate inbound issue status sync from removed feature flag#119079souredoutlook wants to merge 1 commit into
souredoutlook wants to merge 1 commit into
Conversation
Closing or reopening a GitHub issue stopped resolving/unresolving its linked Sentry issue. GitHubIssueSyncSpec.get_resolve_sync_action gated on check_feature_flag(), which checked organizations:integrations-github-project-management. That flag was removed from the registry in #116551 (deemed "zero usage" because the only reference is built dynamically from self.model.provider, so a literal grep missed it). features.has() on an unregistered flag raises FeatureNotRegistered internally and returns False, so get_resolve_sync_action always returned NOOP and the inbound sync silently no-oped. It had previously been registered in #114789 and moved into the spec in #103422. Both github and github_enterprise project-management flags are fully rolled out (GA at 100%), so drop the gate entirely rather than re-register a flag no one maintains, restoring inbound status sync for GitHub and GitHub Enterprise. Fixes GH-110299 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closing or reopening a GitHub issue stopped resolving/unresolving its linked Sentry issue (GitHub → Sentry inbound status sync). Outbound sync (Sentry → GitHub) was unaffected, matching the customer reports.
GitHubIssueSyncSpec.get_resolve_sync_actiongated oncheck_feature_flag(), which checkedorganizations:integrations-github-project-management. That flag was removed from the registry in #116551 — deemed "zero usage" because the only reference builds the flag name dynamically fromself.model.provider, so a literal grep missed it.features.has()on an unregistered flag raisesFeatureNotRegisteredinternally and returnsFalse, soget_resolve_sync_actionalways returnedNOOPand the inbound sync silently no-oped.The flag had previously been registered in #114789 and the check was moved into the shared spec in #103422.
Fix
Both
githubandgithub_enterpriseproject-management flags are fully rolled out (GA at 100% insentry-options-automator), so this drops the gate entirely rather than re-registering a flag no one maintains. This restores inbound status sync for both GitHub and GitHub Enterprise (GHE inheritsGitHubIssueSyncSpec).Fixes GH-110299