Skip to content

chore(quart): Remove transaction-based tracing - #7370

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-transactions-quart
Sep 4, 2026
Merged

chore(quart): Remove transaction-based tracing#7370
sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-transactions-quart

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 3, 2026

Copy link
Copy Markdown

PY-2712

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

99316 passed | ❌ 2 failed | ⏭️ 4494 skipped | Total: 103812 | Pass Rate: 95.67% | Execution Time: 340m 27s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -1589
Passed Tests 📈 +394
Failed Tests 📈 +2
Skipped Tests 📉 -1985

➕ New Tests (1)

View new tests
  • test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing

❌ Failed Tests

test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.83.14
Error: ValueError: too many values to unpack (expected 1)

Stack Trace
tests/integrations/litellm/test_litellm.py:3394: in test_chat_completion_data_collection
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

✅ Patch coverage is 91.67%. Project has 2261 uncovered lines.
✅ Project coverage is 90.39%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/quart.py 91.67% ⚠️ 3 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.39%    +0.15%
==========================================
  Files          193       185        -8
  Lines        25715     23535     -2180
  Branches      9502      8632      -870
==========================================
+ Hits         23206     21274     -1932
- Misses        2509      2261      -248
- Partials      1433      1359       -74

Generated by Codecov Action

("/message/123456", "url", "/message/<message_id>", "route"),
],
)
async def test_transaction_style(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test_span_streaming_transaction_style further down so removed this one

@sentrivana
sentrivana marked this pull request as ready for review September 4, 2026 06:47
@sentrivana
sentrivana requested a review from a team as a code owner September 4, 2026 06:47
@sentrivana
sentrivana merged commit e23be9e into major/3.0 Sep 4, 2026
147 of 149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-transactions-quart branch September 4, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants