Skip to content

chore(sanic): Remove transaction-based tracing - #7369

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-transactions-sanic
Sep 4, 2026
Merged

chore(sanic): Remove transaction-based tracing#7369
sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-transactions-sanic

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 3, 2026

Copy link
Copy Markdown

PY-2717

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

87569 passed | ❌ 2 failed | ⏭️ 4112 skipped | Total: 91683 | Pass Rate: 95.51% | Execution Time: 289m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -46023
Passed Tests 📉 -43027
Failed Tests 📈 +2
Skipped Tests 📉 -2998

➕ New Tests (1)

View new tests
  • test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing

❌ Failed Tests

test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.83.14
Error: ValueError: too many values to unpack (expected 1)

Stack Trace
tests/integrations/litellm/test_litellm.py:3394: in test_chat_completion_data_collection
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

✅ Patch coverage is 100.00%. Project has 2283 uncovered lines.
✅ Project coverage is 90.28%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.28%    +0.04%
==========================================
  Files          193       185        -8
  Lines        25724     23489     -2235
  Branches      9504      8612      -892
==========================================
+ Hits         23214     21206     -2008
- Misses        2510      2283      -227
- Partials      1435      1367       -68

Generated by Codecov Action

"version": "1.1",
"method": "GET",
"transport": None,
"transport": Mock(spec=["get_extra_info"]),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, test_concurrency throws an error on teardown

@sentrivana
sentrivana marked this pull request as ready for review September 4, 2026 09:28
@sentrivana
sentrivana requested a review from a team as a code owner September 4, 2026 09:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b386c02. Configure here.

if isinstance(integration, SanicIntegration) and integration._unsampled_statuses:
logger.warning(
"The `unsampled_statuses` option of SanicIntegration has no effect when span streaming is enabled.",
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default option warns on every request

Medium Severity

The unsampled_statuses warning now runs on every request. The default is {404}, which is truthy, so default SanicIntegration() logs this warning for every incoming request. The message also claims span streaming is enabled even when trace_lifecycle is not stream.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b386c02. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow-up

@sentrivana
sentrivana merged commit 0534d9d into major/3.0 Sep 4, 2026
147 of 149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-transactions-sanic branch September 4, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants