chore(sanic): Remove transaction-based tracing - #7369
Conversation
Codecov Results 📊✅ 87569 passed | ❌ 2 failed | ⏭️ 4112 skipped | Total: 91683 | Pass Rate: 95.51% | Execution Time: 289m 51s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
| "version": "1.1", | ||
| "method": "GET", | ||
| "transport": None, | ||
| "transport": Mock(spec=["get_extra_info"]), |
There was a problem hiding this comment.
Without this, test_concurrency throws an error on teardown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b386c02. Configure here.
| if isinstance(integration, SanicIntegration) and integration._unsampled_statuses: | ||
| logger.warning( | ||
| "The `unsampled_statuses` option of SanicIntegration has no effect when span streaming is enabled.", | ||
| ) |
There was a problem hiding this comment.
Default option warns on every request
Medium Severity
The unsampled_statuses warning now runs on every request. The default is {404}, which is truthy, so default SanicIntegration() logs this warning for every incoming request. The message also claims span streaming is enabled even when trace_lifecycle is not stream.
Reviewed by Cursor Bugbot for commit b386c02. Configure here.
There was a problem hiding this comment.
Will fix in a follow-up


Closes https://linear.app/getsentry/issue/PY-2717/remove-transaction-based-tracing-from-sanic