Skip to content

ref(huggingface_hub): Drop support for stream_gen_ai_spans - #7358

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/huggingface-hub/remove-stream-gen-ai-spans-2
Sep 4, 2026
Merged

ref(huggingface_hub): Drop support for stream_gen_ai_spans#7358
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/huggingface-hub/remove-stream-gen-ai-spans-2

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Set stream_gen_ai_spans=False to maintain assertions for the static trace lifecycle.
Transaction support will be removed as a follow up.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 3, 2026 10:57
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 3, 2026 10:57
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

113905 passed | ❌ 1 failed | ⏭️ 5544 skipped | Total: 119450 | Pass Rate: 95.36% | Execution Time: 384m 30s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -18245
Passed Tests 📉 -16680
Failed Tests 📈 +1
Skipped Tests 📉 -1566

➕ New Tests (1)

View new tests
  • test_async_binary_content_encoding_mixed_content[True-True]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing

❌ Failed Tests

test_async_binary_content_encoding_mixed_content[True-True]

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.83.14
Error: pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(ThreadPoolExecutor-77_1, started 139962984199744)>> Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

Stack Trace
/usr/lib/python3.10/threading.py:973: in _bootstrap
    self._bootstrap_inner()
/usr/lib/python3.10/threading.py:1011: in _bootstrap_inner
    _sys.settrace(_trace_hook)
E   RuntimeError: Cannot install a trace function while another trace function is being installed

The above exception was the direct cause of the following exception:
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/runner.py:361: in from_call
    result: TResult | None = func()
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/runner.py:250: in <lambda>
    lambda: runtest_hook(item=item, **kwds),
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_hooks.py:512: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/logging.py:865: in pytest_runtest_call
    yield
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_callers.py:53: in run_old_style_hookwrapper
    return result.get_result()
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_callers.py:38: in run_old_style_hookwrapper
    res = yield
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/capture.py:900: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/skipping.py:268: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:183: in pytest_runtest_call
    collect_unraisable(item.config)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:79: in collect_unraisable
    raise errors[0]
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:67: in collect_unraisable
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E   pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(ThreadPoolExecutor-77_1, started 139962984199744)>>
E   Enable tracemalloc to get traceback where the object was allocated.
E   See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

✅ Patch coverage is 100.00%. Project has 2264 uncovered lines.
✅ Project coverage is 90.44%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.25%    90.44%    +0.19%
==========================================
  Files          193       185        -8
  Lines        25715     23671     -2044
  Branches      9502      8704      -798
==========================================
+ Hits         23206     21407     -1799
- Misses        2509      2264      -245
- Partials      1435      1365       -70

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 43797f7 into major/3.0 Sep 4, 2026
147 of 149 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/huggingface-hub/remove-stream-gen-ai-spans-2 branch September 4, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants