test: Adapt threading tests to span streaming - #7349
Merged
sentrivana merged 3 commits intoSep 4, 2026
Conversation
Contributor
Codecov Results 📊✅ 117082 passed | ⏭️ 5544 skipped | Total: 122626 | Pass Rate: 95.48% | Execution Time: 379m 19s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2255 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.24% 90.47% +0.23%
==========================================
Files 193 185 -8
Lines 25707 23661 -2046
Branches 9478 8680 -798
==========================================
+ Hits 23198 21406 -1792
- Misses 2509 2255 -254
- Partials 1436 1364 -72Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
September 3, 2026 09:38
alexander-alderman-webb
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threading integration itself doesn't have any streaming branching, which is probably why these two threading tests that have to do with tracing got overlooked.
In streaming, the behavior in the
propagate_scope=Falsecase has changed -- all spans will be emitted. Previously, some of the spans wouldn't be emitted because they would be orphaned child spans.