Skip to content

test: Adapt threading tests to span streaming - #7349

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/move-threading-tests-to-streaming
Sep 4, 2026
Merged

test: Adapt threading tests to span streaming#7349
sentrivana merged 3 commits into
major/3.0from
ivana/major/move-threading-tests-to-streaming

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

The threading integration itself doesn't have any streaming branching, which is probably why these two threading tests that have to do with tracing got overlooked.

In streaming, the behavior in the propagate_scope=False case has changed -- all spans will be emitted. Previously, some of the spans wouldn't be emitted because they would be orphaned child spans.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

117082 passed | ⏭️ 5544 skipped | Total: 122626 | Pass Rate: 95.48% | Execution Time: 379m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -14961
Passed Tests 📉 -13395
Failed Tests
Skipped Tests 📉 -1566

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2255 uncovered lines.
✅ Project coverage is 90.47%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.47%    +0.23%
==========================================
  Files          193       185        -8
  Lines        25707     23661     -2046
  Branches      9478      8680      -798
==========================================
+ Hits         23198     21406     -1792
- Misses        2509      2255      -254
- Partials      1436      1364       -72

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 3, 2026 09:38
@sentrivana
sentrivana requested a review from a team as a code owner September 3, 2026 09:38
@sentrivana
sentrivana merged commit b227ea6 into major/3.0 Sep 4, 2026
149 checks passed
@sentrivana
sentrivana deleted the ivana/major/move-threading-tests-to-streaming branch September 4, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants