Skip to content

ref(mcp): Inline _set_span_output_data()#6762

Open
alexander-alderman-webb wants to merge 3 commits into
webb/mcp/use-middleware-2from
webb/mcp/use-middleware-3
Open

ref(mcp): Inline _set_span_output_data()#6762
alexander-alderman-webb wants to merge 3 commits into
webb/mcp/use-middleware-2from
webb/mcp/use-middleware-3

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unnecessary indirection by inlining _set_span_output_data().

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title ref(mcp): Inline _set_span_output_data() ref(mcp): Inline _set_span_output_data() Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90034 passed | ⏭️ 6302 skipped | Total: 96336 | Pass Rate: 93.46% | Execution Time: 312m 39s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -11
Passed Tests 📉 -11
Failed Tests
Skipped Tests

All tests are passing successfully.

❌ Patch coverage is 78.57%. Project has 2489 uncovered lines.
❌ Project coverage is 89.58%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/mcp.py 78.57% ⚠️ 12 Missing and 12 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.73%    89.58%    -0.15%
==========================================
  Files          192       192         —
  Lines        23823     23898       +75
  Branches      8226      8242       +16
==========================================
+ Hits         21378     21409       +31
- Misses        2445      2489       +44
- Partials      1349      1354        +5

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review July 7, 2026 11:24
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner July 7, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant