feat(billing): Add seat activity and seats service protos - #411
Draft
volokluev wants to merge 5 commits into
Draft
feat(billing): Add seat activity and seats service protos#411volokluev wants to merge 5 commits into
volokluev wants to merge 5 commits into
Conversation
- Add seat_activity service endpoints: close_contract, get_original_seat_dates, get_seat_activity_history, get_seat_contract_state, get_seat_state, perform_seat_actions - Add seats service endpoints: assign_seat, check_assign_seats, disable_seat, get_daily_seat_usage, get_daily_seat_usage_by_project, get_seat_status, remove_seat, rollover_seats, update_seat_identifier - Define shared types: SeatStatus, SeatObject, SeatState, SeatActionRecord, ExternalProductSeatActivity, SeatActionItem, OriginalSeatDate, ExternalProductSeatStatus, SeatAssignmentOutcome, ProjectSeatUsage
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
Move SeatStatus into billing/v1/common/v1/seat_status.proto so both seat_activity and seats services share one enum. Remove the duplicate ExternalProductSeatStatus from seats/v1/seats.proto.
Add documentation comments to all seat_activity and seats service proto messages explaining what each endpoint does, its constraints, and any notable behavior (e.g. OVER_QUOTA -> DISABLED mapping, idempotent rollover, high-throughput check-in path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proto definitions for two new billing services:
seat_activity service
CloseContract- close a seat contractGetOriginalSeatDates- get original creation dates for seatsGetSeatActivityHistory- get seat activity history for a contractGetSeatContractState- check if a seat contract exists and is activeGetSeatState- get the current state of a seatPerformSeatActions- perform batch seat actionsseats service
AssignSeat- assign a seatCheckAssignSeats- check if seats can be assignedDisableSeat- disable a seatGetDailySeatUsage- get daily seat usageGetDailySeatUsageByProject- get daily seat usage by projectGetSeatStatusForExternalProduct- get seat status for an external productRemoveSeat- remove a seatRolloverSeatsToNewContract- rollover seats to a new contractUpdateSeatIdentifier- update a seat identifierShared types
SeatStatus(consolidated intobilling/v1/common/v1/seat_status.proto— shared by both services)SeatObject,SeatState,SeatActionRecord,ExternalProductSeatActivity,SeatActionItem,OriginalSeatDateSeatAssignmentOutcome,ProjectSeatUsageDependencies