fix(native): daemon constructs breadcrumbs from file#1775
Merged
Conversation
native_backend_flush_scope runs on every scope mutation (set_tag, set_context, set_user, ...). Folding breadcrumbs into the flushed base event re-serialized the entire breadcrumb ring on each of those calls - prohibitive on a hot path such as a 60fps game main thread. Give apply_scope a scope-mode argument: the continuous flush now passes SENTRY_SCOPE_NONE, while the crash handler still passes SENTRY_SCOPE_BREADCRUMBS to capture them at crash time (the process's last chance to record them). This matches the pre-existing behavior before breadcrumbs were added to the shared flush path. Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
bitsandfoxes
commented
Jun 3, 2026
| return; | ||
| } | ||
|
|
||
| // Serialize to JSON (so it can be deserialized on next start) |
Contributor
Author
There was a problem hiding this comment.
That comment is misleading, could not find who or what was reading the JSON on the next start.
bitsandfoxes
commented
Jun 3, 2026
| uint64_t shutdown_timeout; | ||
| uint64_t transfer_timeout; | ||
| bool system_crash_reporter_enabled; | ||
| uint32_t max_breadcrumbs; |
Contributor
Author
There was a problem hiding this comment.
Since it's the daemon now constructing the breadcrumbs from files it needs the max_breadcrumbs.
bitsandfoxes
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a5a6be. Configure here.
Contributor
|
Let's also write some unit and integration tests to verify this works end-to-end on all 3 platforms |
mujacica
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #1769
The Goal
The goal is to have the daemon create non-crashing events that have the same scope as crashing ones. The non-crashing event created by the app hang detection was missing breadcrumbs.
Context
The crash capture works by the in-process part of the SDK maintaining a base event that the daemon later can pick up, enrich and send. This base event also contains the flushed scope.
Breadcrumbs live on the scope but do not get flushed when added:
sentry-native/src/sentry_core.c
Lines 936 to 941 in 259c59a
So the
native_backend_exceptrunning in-process has to flush the scope including the breadcrumbs to have them in the base event for them to be available in the event sent by the daemon.sentry-native/src/backends/sentry_backend_native.c
Lines 1027 to 1031 in 259c59a
That also means that the daemon never touched the breadcrumb ringfiles.
What This Does
Instead of relying on the
native_backend_exceptto sync the breadcrumbs to the base event (which won't be happening in case of non-crashing events) we make the daemon pick up the breadcrumbs that are written to file anyway.#skip-changelog