Conversation
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
September 24, 2026 22:11
Contributor
size-limit report 📦
|
JPeer264
reviewed
Sep 25, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Implementation LGTM. However I'm not sure if we should send vercel.ai specific attributes. I added @andreiborza and @RulaKhaled who know more about status quo on these fields and if we should (re-)add them
RulaKhaled
reviewed
Sep 25, 2026
RulaKhaled
left a comment
RulaKhaled
left a comment
Collaborator
There was a problem hiding this comment.
Also lgtm. I’d bring this up in the agent tracing channel before merging, vercel.ai.telemetry.metadata.* attributes aren’t in @sentry/conventions, they probably can’t be convention constants but maybe we could register a prefix
| const baseAttributes: Record<string, string | number | boolean> = { | ||
| const baseAttributes: SpanAttributes = { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: ORIGIN, | ||
| ...telemetryMetadataAttributes(event.telemetryMetadata), |
Collaborator
There was a problem hiding this comment.
I wonder if this should be gated on recordInputs or dataCollection.genAI
… on gen_ai spans v10 got `vercel.ai.telemetry.metadata.<key>` attributes from the AI SDK's own OTel spans. In v11, `ai` 4 to 6 go through the orchestrion subscriber, which never read `metadata`, so v11 dropped it. The orchestrion subscriber now passes the metadata to the channel subscriber, which sets it as span attributes when each span starts. The `invoke_agent`, `generate_content` and `embeddings` spans get the attributes, and `execute_tool` spans don't. This matches the AI SDK, which leaves metadata off its `ai.toolCall` spans. fixes JS-3800 fixes #24720 Re: #24706 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
force-pushed
the
isaacschlueter/js-3800-vercelaiintegration-experimental_telemetrymetadata-no-longer
branch
from
September 25, 2026 17:53
e652f6b to
aea4552
Compare
Member
Author
Good call! Pinged them for input. |
…n-experimental_telemetrymetadata-no-longer
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| if (isObjectLike(metadata)) { | ||
| for (const [key, value] of Object.entries(metadata)) { | ||
| attributes[`${VERCEL_AI_TELEMETRY_METADATA_ATTRIBUTE_PREFIX}${key}`] = value as SpanAttributeValue; | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: The telemetryMetadataAttributes function improperly handles non-primitive metadata values, leading to data corruption when they are cast to SpanAttributeValue without validation.
Severity: MEDIUM
Suggested Fix
Before assigning the value as a span attribute, check if it is a primitive type. If it is not a primitive, attempt to serialize it using JSON.stringify within a try-catch block to handle potential serialization errors gracefully. This aligns with the existing SDK pattern for handling user-provided data.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/server-utils/src/integrations/vercel-ai/vercel-ai-dc-subscriber.ts#L481
Potential issue: The `telemetryMetadataAttributes` function casts values from
`experimental_telemetry.metadata` to `SpanAttributeValue` without proper type
validation. The `SpanAttributeValue` type is restricted to primitives and arrays of
primitives, but the input metadata can contain nested objects. When a span with a
non-primitive attribute is serialized for Sentry, the object is converted to the string
`"[object Object]"`, leading to corrupted or lost telemetry data. This behavior is
inconsistent with established SDK patterns that safely handle user-provided objects by
checking for primitives and using `JSON.stringify` for complex types.
Did we get this right? 👍 / 👎 to inform future reviews.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v10 got
vercel.ai.telemetry.metadata.<key>attributes from the AI SDK's own OTel spans. In v11,ai4 to 6 go through the orchestrion subscriber, which never readmetadata, so v11 dropped it.The orchestrion subscriber now passes the metadata to the channel subscriber, which sets it as span attributes when each span starts. The
invoke_agent,generate_contentandembeddingsspans get the attributes, andexecute_toolspans don't. This matches the AI SDK, which leaves metadata off itsai.toolCallspans.fixes JS-3800
fixes #24720
Re: #24706