ref(api)!: Remove legacy hybrid SDK facade - #8909
Draft
philprime wants to merge 6 commits into
Draft
Conversation
7 tasks
Move PrivateSentrySDKOnly out of public framework headers after hybrid SDKs migrated to SentrySDK.internal. Inline remaining internal access paths and regenerate the public API definitions.
philprime
force-pushed
the
philprime/remove-private-sdk-api
branch
from
September 1, 2026 11:21
8b6a4b3 to
7e53dc2
Compare
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc4e913 | 1231.79 ms | 1267.89 ms | 36.11 ms |
| 6f28fd8 | 1229.98 ms | 1271.73 ms | 41.75 ms |
| a7c42d9 | 1217.25 ms | 1253.98 ms | 36.73 ms |
| 230cc86 | 1225.33 ms | 1258.67 ms | 33.34 ms |
| 5556249 | 1208.87 ms | 1246.60 ms | 37.72 ms |
| 8ed81c1 | 1227.47 ms | 1249.24 ms | 21.77 ms |
| 92fada5 | 1217.60 ms | 1252.89 ms | 35.30 ms |
| 6d9f89d | 1226.37 ms | 1260.94 ms | 34.57 ms |
| 318f8af | 1213.09 ms | 1246.21 ms | 33.13 ms |
| 01ffe09 | 1208.52 ms | 1240.94 ms | 32.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc4e913 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 6f28fd8 | 24.14 KiB | 1.30 MiB | 1.28 MiB |
| a7c42d9 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 230cc86 | 24.14 KiB | 1.25 MiB | 1.23 MiB |
| 5556249 | 24.14 KiB | 1.29 MiB | 1.27 MiB |
| 8ed81c1 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
| 92fada5 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 6d9f89d | 24.14 KiB | 1.26 MiB | 1.23 MiB |
| 318f8af | 24.14 KiB | 1.30 MiB | 1.28 MiB |
| 01ffe09 | 24.14 KiB | 1.29 MiB | 1.27 MiB |
Previous results on branch: philprime/remove-private-sdk-api
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5519155 | 1234.87 ms | 1267.30 ms | 32.43 ms |
| 9b5a8b4 | 1220.10 ms | 1263.90 ms | 43.80 ms |
| 1a8fbc1 | 1209.24 ms | 1246.44 ms | 37.19 ms |
| 29c45c5 | 1230.60 ms | 1264.31 ms | 33.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5519155 | 24.14 KiB | 1.31 MiB | 1.29 MiB |
| 9b5a8b4 | 24.14 KiB | 1.31 MiB | 1.29 MiB |
| 1a8fbc1 | 24.14 KiB | 1.32 MiB | 1.29 MiB |
| 29c45c5 | 24.14 KiB | 1.31 MiB | 1.29 MiB |
philprime
marked this pull request as ready for review
September 4, 2026 09:19
philprime
requested review from
a team,
NinjaLikesCheez,
itaybre and
noahsmartin
as code owners
September 4, 2026 09:19
philprime
marked this pull request as draft
September 4, 2026 09:26
Delete PrivateSentrySDKOnly after supported hybrid SDKs migrated to the structured internal API. Update tests and maintainer guidance to use the current entry points directly.
philprime
marked this pull request as ready for review
September 4, 2026 09:41
NinjaLikesCheez
approved these changes
Sep 4, 2026
…ate-sdk-api # Conflicts: # Tests/SentryTests/PrivateSentrySDKOnlyTests.swift
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a1d51d7. Configure here.
philprime
marked this pull request as draft
September 4, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Remove
PrivateSentrySDKOnlycompletely now that supported hybrid SDKs useSentrySDK.internaland Objective-C consumers useSentryObjCSDK.internal. The legacy header, implementation, Objective-C runtime symbol, build references, dedicated tests, and test-plan entries are gone.Implementation
SentrySDKInternal, with the structured app-start and performance APIs using that shared state.SentryInternalAppStartApiand use the structured internal APIs at SDK and test call sites.SentryObjCPrivateSDKOnlyas an independent SentryObjC compatibility surface, but delegate it directly toSentrySDK.internalrather than the removed class.SENTRY-INTERNAL-API.mdto an entry-point, source-navigation, architecture, and test-location guide instead of duplicating API declarations or migration history.This intentionally removes the unsupported
PrivateSentrySDKOnlysource and runtime compatibility surface. All supported React Native, Flutter, .NET, and Unity integrations have migrated to the structured APIs.#skip-changelog
Validation
make formatmake analyzemake generate-public-apimake build-ios FOR_AGENTS=truemake build-macos FOR_AGENTS=truemake test-ios FOR_AGENTS=true, including 5,632 Sentry tests and 971 SentryV10 tests with zero failuresLocal sample validation could not complete because the XCFramework sample artifacts were absent and the source sample encountered a stale duplicate-module cache conflict before compiling the changed sample source.
Checklist
sendDefaultPIIis enabled.Closes #8908