Skip to content

fix(editor): restore spacing between slider labels and values - #384

Open
tebuevd wants to merge 1 commit into
getopenscreen:mainfrom
tebuevd:dinislam/fix-spacing
Open

fix(editor): restore spacing between slider labels and values#384
tebuevd wants to merge 1 commit into
getopenscreen:mainfrom
tebuevd:dinislam/fix-spacing

Conversation

@tebuevd

@tebuevd tebuevd commented Aug 16, 2026

Copy link
Copy Markdown

Summary

Used OpenScreen for the first time today and noticed the spacing issue (see screenshot section below). Turns out the CSS module styles weren't being applied due to a typo class="head" // wrong instead of class={styles.head} // correct. So it was a very simple fix.

I verified via npm dev on macOS. This is my first time contributing to OpenScreen, so let me know if there are additional steps to follow etc. Thanks!

Related issue

Fixes #

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

I only tested on macOS, but I assume this affects all of them, so ticking "Not platform-specific".

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

Before

Spacing is broken:

SCR-20260815-pagw

After

Spacing is fixed 😀

SCR-20260815-pjkn

Testing

npm dev, then verified in the Electron window.

Summary by CodeRabbit

  • Style
    • Updated webcam and slider header styling to use scoped component styles.
    • No user-facing behavior or functionality changed.

@tebuevd
tebuevd requested a review from EtienneLescot as a code owner August 16, 2026 00:34
@tebuevd tebuevd changed the title fix(editor): $estore spacing between slider labels and values fix(editor): restore spacing between slider labels and values Aug 16, 2026
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ce232e6-413a-43eb-94ab-f50799d62dc9

📥 Commits

Reviewing files that changed from the base of the PR and between c477979 and 7d619d5.

📒 Files selected for processing (1)
  • src/components/ai-edition/RightPanes.tsx

📝 Walkthrough

Walkthrough

The change replaces global slider header class names with CSS module classes in the webcam size control and SliderCell. Existing conditional value rendering remains unchanged.

Changes

Scoped slider header styling

Layer / File(s) Summary
Apply scoped slider classes
src/components/ai-edition/RightPanes.tsx
The webcam size control and SliderCell now use styles.head, styles.label, and styles.val. Slider value display logic remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7d619

This localized styling fix restores spacing between slider labels and values without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: etiennelescot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the spacing fix for slider labels and values.
Description check ✅ Passed The description covers the change, classifications, release impact, platform impact, screenshots, and testing; the related issue number is empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant