fix(editor): restore spacing between slider labels and values - #384
fix(editor): restore spacing between slider labels and values#384tebuevd wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change replaces global slider header class names with CSS module classes in the webcam size control and ChangesScoped slider header styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized styling fix restores spacing between slider labels and values without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Used OpenScreen for the first time today and noticed the spacing issue (see screenshot section below). Turns out the CSS module styles weren't being applied due to a typo
class="head" // wronginstead ofclass={styles.head} // correct. So it was a very simple fix.I verified via
npm devon macOS. This is my first time contributing to OpenScreen, so let me know if there are additional steps to follow etc. Thanks!Related issue
Fixes #
Type of change
Release impact
Desktop impact
I only tested on macOS, but I assume this affects all of them, so ticking "Not platform-specific".
Screenshots / video
Before
Spacing is broken:
After
Spacing is fixed 😀
Testing
npm dev, then verified in the Electron window.Summary by CodeRabbit