Edit Docs inline and review agent proposals - #3953
Merged
brsbl merged 38 commits intoSep 21, 2026
Merged
Conversation
This reverts commit c7e5e49.
brsbl
deleted the
bb/specify-agent-data-visualization-plugin-thr_jr837d4mma
branch
September 21, 2026 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Docs replies only linked to a separate editor, and direct agent edits had no approval step. The Document action opened an empty panel when no document was attached.
What changed
How you verified
125d81b8f: tests, build, typecheck, lint, and packaging smoke checks.User QA is pending. Screenshots retain their actual capture revisions; the full matrix was not recaptured at the latest head.
Validation scope and known follow-ups
Browser evidence uses desktop 1440 × 900 and mobile 390 × 844 at 2× density:
125d81b8f: desktop HTML workspace/panel titles, sizing, sandbox, interactive scripts, and reload passed without page errors.907bc4804: desktop live diffs, typing, shared card/tab edits, proposal transitions, autosave, Escape, and reload passed.8243e10a5: desktop/mobile truncated previews opened editable tabs; keyboard activation passed.44283adfa: desktop/mobile document selection, search, vault switching, and restored tabs passed.Regression tests protect stale-write conflicts, save ordering, proposal transitions, cursor behavior, inert parsing, and proposal move/delete cleanup. The navigation-cache regression failed before its fix and passed afterward.
The feature uses existing BB and SDK surfaces. Shared editors, autosave sessions, and HTML previews avoid separate implementations per surface.
The five-panel review at
c7e5e4986found no P0/P1 issues. It predates the document-picker replacement and later consolidations. Four P2 follow-ups remain:Marketplace gallery: six screenshots cover inline editing, proposal review, mobile requests for changes, Markdown workspace, HTML preview, and vault setup. Release dependency: marketplace PR #336 must publish its assets before shipping these URLs.
Marketplace gallery captures use Chrome for Testing 153.0.8010.47 at 2×. Revisions are labeled in the filenames.
Additional proposal states:
Loading-state captures:
baf8a71c9, Chrome for Testing 153.0.8010.47, light theme, 2× pixels. Both headers use the sidebar's sharedLoadingicon.Earlier Copy button captures:
b461fea1d, Chrome for Testing 153.0.8010.47, light theme, 2× pixels.Earlier loading-state captures:
2e52b77c4, Chrome for Testing 153.0.8010.47, light theme, 2× pixels. Requests were held open while the real document stayed visible.Evidence limitation: release-hosted images render inline but their full-size URLs force downloads. Non-download viewing links remain unavailable. The comprehensive before/after matrix below retains its original revision labels; it has not been recaptured at the latest head. User QA remains pending.
Screenshots use the same source app, fixture, routes, light theme, viewport, and 2× pixel density. Before is merge base
c1a64f4b4; after is the previously verified feature revisionb787f397a. The original timeline had a link card; the repeated before images make the absence of inline editing and proposal controls explicit.Desktop · 1440 × 900 — before / after
Mobile · 390 × 844 — before / after
Document selection (
44283adfa): search, vault switching, opening files in thread tabs, and reload restoration passed on desktop/mobile at 2×.Bounded inline documents
Before:
c1a64f4b4(original linked cards). After:8243e10a5. Same documents, route, viewport, and 2× density.Markdown verification (
907bc4804):HTML verification (
125d81b8f):BB-Thread-ID: thr_jr837d4mma