Skip to content

Edit Docs inline and review agent proposals - #3953

Merged
brsbl merged 38 commits into
mainfrom
bb/specify-agent-data-visualization-plugin-thr_jr837d4mma
Sep 21, 2026
Merged

brsbl merged 38 commits into
mainfrom
bb/specify-agent-data-visualization-plugin-thr_jr837d4mma

Conversation

@brsbl

@brsbl brsbl commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Docs replies only linked to a separate editor, and direct agent edits had no approval step. The Document action opened an empty panel when no document was attached.

What changed

  • Edit Markdown in threads and tabs with shared autosave, cached drafts, Copy, and loading feedback.
  • Review editable agent proposals with word-level diffs, Accept/Reject, Undo/Redo, and requests for further changes.
  • Click previews taller than 400px to continue editing in a tab.
  • Browse, search, and select documents from the Document panel.
  • Add version-checked proposal CLI/RPC operations, agent guidance, and updated marketplace copy and screenshots.

How you verified

  • Remote CI passed at 125d81b8f: tests, build, typecheck, lint, and packaging smoke checks.
  • Chrome for Testing 153.0.8010.47 passed editing, proposal transitions, shared drafts, navigation, and reload checks.
  • Desktop/mobile checks passed for truncation, keyboard activation, document selection, loading feedback, and Copy.

User QA is pending. Screenshots retain their actual capture revisions; the full matrix was not recaptured at the latest head.

Validation scope and known follow-ups

Browser evidence uses desktop 1440 × 900 and mobile 390 × 844 at 2× density:

  • 125d81b8f: desktop HTML workspace/panel titles, sizing, sandbox, interactive scripts, and reload passed without page errors.
  • 907bc4804: desktop live diffs, typing, shared card/tab edits, proposal transitions, autosave, Escape, and reload passed.
  • 8243e10a5: desktop/mobile truncated previews opened editable tabs; keyboard activation passed.
  • 44283adfa: desktop/mobile document selection, search, vault switching, and restored tabs passed.
  • Earlier labeled captures cover editing, mentions, conflicts, navigation caching, Copy, and delayed-action progress.

Regression tests protect stale-write conflicts, save ordering, proposal transitions, cursor behavior, inert parsing, and proposal move/delete cleanup. The navigation-cache regression failed before its fix and passed afterward.

The feature uses existing BB and SDK surfaces. Shared editors, autosave sessions, and HTML previews avoid separate implementations per surface.

The five-panel review at c7e5e4986 found no P0/P1 issues. It predates the document-picker replacement and later consolidations. Four P2 follow-ups remain:

  • Dirty inline conflicts need explicit discard/reload recovery.
  • Replacing a proposal baseline can reuse stale deletion-widget text.
  • Large proposal CLI responses can exceed the output cap after mutation.
  • Proposal-only autosaves can trigger full-vault scans.

Marketplace gallery: six screenshots cover inline editing, proposal review, mobile requests for changes, Markdown workspace, HTML preview, and vault setup. Release dependency: marketplace PR #336 must publish its assets before shipping these URLs.

Updated Docs marketplace listing — branch preview with pending CDN assets served locally

Marketplace gallery captures use Chrome for Testing 153.0.8010.47 at 2×. Revisions are labeled in the filenames.

Feature Screenshot
Inline proposal review and document tab Inline proposal review and document tab
Direct inline editing Direct inline editing
Mobile: ask for changes Mobile: ask for changes
Markdown workspace Markdown workspace
HTML preview HTML preview
Connect a vault Connect a vault

Additional proposal states:

Accepted Rejected
Accepted Rejected
Undo Redo
Undo Redo

Loading-state captures: baf8a71c9, Chrome for Testing 153.0.8010.47, light theme, 2× pixels. Both headers use the sidebar's shared Loading icon.

State Desktop · 1440 × 900 Mobile · 390 × 844
Updating document Sidebar loading icon in document headers Sidebar loading icon on mobile

Earlier Copy button captures: b461fea1d, Chrome for Testing 153.0.8010.47, light theme, 2× pixels.

State Desktop · 1440 × 900 Mobile · 390 × 844
Persistent Copy action Copy in timeline and tab headers Copy in the mobile header

Earlier loading-state captures: 2e52b77c4, Chrome for Testing 153.0.8010.47, light theme, 2× pixels. Requests were held open while the real document stayed visible.

State Desktop · 1440 × 900 Mobile · 390 × 844
Accept in progress Accept in progress in timeline and tab Accept in progress on mobile

Evidence limitation: release-hosted images render inline but their full-size URLs force downloads. Non-download viewing links remain unavailable. The comprehensive before/after matrix below retains its original revision labels; it has not been recaptured at the latest head. User QA remains pending.

Screenshots use the same source app, fixture, routes, light theme, viewport, and 2× pixel density. Before is merge base c1a64f4b4; after is the previously verified feature revision b787f397a. The original timeline had a link card; the repeated before images make the absence of inline editing and proposal controls explicit.

Desktop · 1440 × 900 — before / after

State or screen Before — c1a64f4 After — b787f39
Read in the timeline Before: Read in the timeline, desktop After: Read in the timeline, desktop
Edit in the timeline Before: Edit in the timeline, desktop After: Edit in the timeline, desktop
Pending revision · word-level diff Before: Pending revision · word-level diff, desktop After: Pending revision · word-level diff, desktop
Edit a pending revision Before: Edit a pending revision, desktop After: Edit a pending revision, desktop
Reject · Undo available Before: Reject · Undo available, desktop After: Reject · Undo available, desktop
Accept · Undo available Before: Accept · Undo available, desktop After: Accept · Undo available, desktop
Undo · Redo available Before: Undo · Redo available, desktop After: Undo · Redo available, desktop
Redo · proposal reopened Before: Redo · proposal reopened, desktop After: Redo · proposal reopened, desktop
Ask for changes · document mention Before: Ask for changes · document mention, desktop After: Ask for changes · document mention, desktop
Document tab Before: Document tab, desktop After: Document tab, desktop
Docs workspace editor Before: Docs workspace editor, desktop After: Docs workspace editor, desktop
Standalone Markdown editor Before: Standalone Markdown editor, desktop After: Standalone Markdown editor, desktop
Standalone file changed on disk Before: Standalone file changed on disk, desktop After: Standalone file changed on disk, desktop

Mobile · 390 × 844 — before / after

State or screen Before — c1a64f4 After — b787f39
Read in the timeline Before: Read in the timeline, mobile After: Read in the timeline, mobile
Edit in the timeline Before: Edit in the timeline, mobile After: Edit in the timeline, mobile
Pending revision · word-level diff Before: Pending revision · word-level diff, mobile After: Pending revision · word-level diff, mobile
Edit a pending revision Before: Edit a pending revision, mobile After: Edit a pending revision, mobile
Reject · Undo available Before: Reject · Undo available, mobile After: Reject · Undo available, mobile
Accept · Undo available Before: Accept · Undo available, mobile After: Accept · Undo available, mobile
Undo · Redo available Before: Undo · Redo available, mobile After: Undo · Redo available, mobile
Redo · proposal reopened Before: Redo · proposal reopened, mobile After: Redo · proposal reopened, mobile
Ask for changes · document mention Before: Ask for changes · document mention, mobile After: Ask for changes · document mention, mobile
Document tab Before: Document tab, mobile After: Document tab, mobile
Docs workspace editor Before: Docs workspace editor, mobile After: Docs workspace editor, mobile
Standalone Markdown editor Before: Standalone Markdown editor, mobile After: Standalone Markdown editor, mobile
Standalone file changed on disk Before: Standalone file changed on disk, mobile After: Standalone file changed on disk, mobile

Document selection (44283adfa): search, vault switching, opening files in thread tabs, and reload restoration passed on desktop/mobile at 2×.

State Desktop Mobile
Choose a document Document picker Mobile document picker
Open selected document Selected document Mobile selected document

Bounded inline documents

Before: c1a64f4b4 (original linked cards). After: 8243e10a5. Same documents, route, viewport, and 2× density.

Viewport Before After
Desktop Before After
Mobile Before After

Markdown verification (907bc4804):

Shared card and tab proposal after consolidation

HTML verification (125d81b8f):

Workspace Thread panel
Workspace HTML preview Thread HTML preview

BB-Thread-ID: thr_jr837d4mma

AGENT GENERATED

@brsbl brsbl changed the title Make Docs editable in chat with reviewable revisions Edit Docs in chat and review agent revisions Sep 19, 2026
@brsbl brsbl changed the title Edit Docs in chat and review agent revisions Edit Docs inline and review proposed revisions Sep 19, 2026
@brsbl brsbl changed the title Edit Docs inline and review proposed revisions Edit Docs inline and approve proposed revisions Sep 20, 2026
@brsbl brsbl changed the title Edit Docs inline and approve proposed revisions Edit Docs inline and review agent proposals Sep 20, 2026
@brsbl brsbl changed the title Edit Docs inline and review agent proposals Edit Docs inline and approve agent revisions Sep 20, 2026
@brsbl brsbl changed the title Edit Docs inline and approve agent revisions Edit Docs inline and review agent proposals Sep 21, 2026
@brsbl
brsbl merged commit 1988935 into main Sep 21, 2026
16 checks passed
@brsbl
brsbl deleted the bb/specify-agent-data-visualization-plugin-thr_jr837d4mma branch September 21, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant