Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
“New thread in environment” passed the environment to the composer but omitted the source thread’s section. The composer cleared its section target, so a new thread created from a thread in section A landed in the unsectioned Threads list.
What changed
Pass the source section through the shared environment creation action from the thread view, environment details, and sidebar environment groups. Creating from section A now keeps the new thread in section A; an unsectioned source explicitly clears any previous section target.
How you verified
pnpm exec turbo run test --filter=@bb/app -- useCreateThreadInEnvironment.test.ts RootComposeView.test.ts ProjectRow.interactions.test.tsx— 82 tests passed, including section preservation and unsectioned-source coverage.pnpm exec turbo run typecheck --filter=@bb/app— passed.pnpm start:worktree; server and daemon health checks passed.