Skip to content

Search saved messages and protect CLI draft saves - #3930

Closed
brsbl wants to merge 12 commits into
mainfrom
bb/draft-lifecycle-thr_82jtfaq8eq
Closed

brsbl wants to merge 12 commits into
mainfrom
bb/draft-lifecycle-thr_82jtfaq8eq

Conversation

@brsbl

@brsbl brsbl commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Thread search ignored saved queued-message text. CLI save-only requests could dispatch work when the Drafts handler was unavailable.

What changed

  • Search saved first messages and follow-ups through their owning threads.
  • Maintain queued-message search entries on save, edit, and delete without inventing timeline anchors.
  • Add bb thread spawn --draft and tell --draft, rejecting requests when Drafts cannot hold the message.

Migration 0128_queued_message_search backfills the existing FTS index. CLI guides are updated; no separate draft resource or daemon protocol is introduced.

How you verified

  • Exact-source CI and PR CI passed at 55c762560a4b3588c566477df397493b12abc65f.
  • Source SDK saves stayed held without a turn; queued-text searches returned their owning active and archived threads.
  • Database regressions passed for backfill, edit/delete maintenance, hidden text, deduplication, filtering, and pagination.

Review and scope

The cumulative Slop Cop review covered 963171ce1f38032e34bdd41c17a7454815504174..723fe1c753f7249d45c604b017f78a8b237e53e6: no P0/P1 findings. The approved cleanup subsequently removed the unshipped Drafts lifecycle API and its classification-only tests; no second review ran.

Slim PR removed draft thread classification, lifecycle list/search flags, the extra response group, queue-count projection, and unused fixtures. Save draft safety and saved-message indexing remain. Existing list/search contracts are preserved.

Recorded P2 follow-ups:

  • Sending a saved structured /clear can clear context without consuming its queued row.

Nothing merged.

BB-Thread-ID: thr_82jtfaq8eq

AGENT GENERATED

@brsbl brsbl changed the title Add saved-draft lifecycle filtering and CLI save actions Search saved messages and protect CLI draft saves Sep 21, 2026
@brsbl

brsbl commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

Deferred at the author’s request. Saved-message search and CLI save-only protection are being punted. Preserving the branch and commits; no merge. The dependent sidebar and palette PRs need to be detached from this deferred foundation before they can ship.

@brsbl brsbl closed this Sep 21, 2026
@brsbl
brsbl removed this pull request from stack #3934 September 21, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant