Conversation
brsbl
marked this pull request as ready for review
September 19, 2026 03:43
brsbl
added this pull request to stack #3934
September 19, 2026 03:52
This was referenced Sep 19, 2026
Collaborator
Author
|
Deferred at the author’s request. Saved-message search and CLI save-only protection are being punted. Preserving the branch and commits; no merge. The dependent sidebar and palette PRs need to be detached from this deferred foundation before they can ship. |
brsbl
removed this pull request from stack #3934
September 21, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Thread search ignored saved queued-message text. CLI save-only requests could dispatch work when the Drafts handler was unavailable.
What changed
bb thread spawn --draftandtell --draft, rejecting requests when Drafts cannot hold the message.Migration
0128_queued_message_searchbackfills the existing FTS index. CLI guides are updated; no separate draft resource or daemon protocol is introduced.How you verified
55c762560a4b3588c566477df397493b12abc65f.Review and scope
The cumulative Slop Cop review covered
963171ce1f38032e34bdd41c17a7454815504174..723fe1c753f7249d45c604b017f78a8b237e53e6: no P0/P1 findings. The approved cleanup subsequently removed the unshipped Drafts lifecycle API and its classification-only tests; no second review ran.Slim PR removed draft thread classification, lifecycle list/search flags, the extra response group, queue-count projection, and unused fixtures. Save draft safety and saved-message indexing remain. Existing list/search contracts are preserved.
Recorded P2 follow-ups:
/clearcan clear context without consuming its queued row.Nothing merged.
BB-Thread-ID: thr_82jtfaq8eq