Keep project indicators fixed on the thread tree guide - #3928
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Cross-project indicators followed truncated thread titles, so revealing row actions on hover moved the indicators horizontally.
What changed
How you verified
Chrome for Testing 153.0.8010.36: desktop and mobile lists with nested, pinned, active, unread, and error threads.
Hover keeps the indicator fixed; tooltip, selection, and action-menu behavior passed on the exact branch head.
PR CI passed, including app tests and Linux/macOS package smoke checks.
Slop Cop review: pass with one follow-up
Reviewed head
3a1e7926b4bddf2a6ed07cc93fb39e82db51e5e5against merge basee865697f56bea89f3413dd4cc7fae964850d20a0.Scope:
git diff e865697f56bea89f3413dd4cc7fae964850d20a0 3a1e7926b4bddf2a6ed07cc93fb39e82db51e5e5 -- apps/app/src/components/sidebar/ThreadRow.tsx.P2 follow-up: A cross-project icon can show a lighter square inside an unfocused split row.
The unconditional
bg-sidebarutility atThreadRow.tsx:475overrides the shared split-state background.Omitting that base utility for inactive split indicators would restore the row tint while preserving hover/menu states.
Verify leaf and sticky-parent indicators at rest, on hover, with actions open, and selected.
This non-blocking follow-up remains outside this PR under the review policy.
Before and after
Before: freshly fetched
origin/mainat2c9fdf2dc02f09fb16003658f148bbd362cff0c2. After:3a1e7926b4bddf2a6ed07cc93fb39e82db51e5e5.Same isolated fixture, routes, interactions, light theme, scroll positions, and 2× density on both revisions.
Desktop · 1440 × 900
Mobile · 390 × 844
BB-Thread-ID: thr_xqz2cxmmac