Skip to content

Send queued messages with Enter when Enter steers - #3927

Merged
brsbl merged 8 commits into
mainfrom
bb/update-composer-enter-behavior-thr_k3vhrnr4cw
Sep 21, 2026
Merged

brsbl merged 8 commits into
mainfrom
bb/update-composer-enter-behavior-thr_k3vhrnr4cw

Conversation

@brsbl

@brsbl brsbl commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The Enter-steers setting swapped submission callbacks without their input requirements, preventing Enter from sending queued messages from an empty composer.

What changed

  • Both settings share submission callbacks and eligibility rules; the setting swaps which shortcut triggers each action.
  • Enter sends queued messages when Enter steers; Cmd+Enter sends them when Enter queues.
  • Draft steering, queueing, and the empty composer's Stop action retain their existing behavior.

How you verified

  • Rebased onto 1988935a9 without conflicts; git range-diff confirms every layer commit retains its original patch.

  • Merged layer head: 7ea59252222280bf1645bbc9c35b5b83e473798a. Rebase CI passed.

  • The new base changes Docs only. Existing composer review and QA evidence remain applicable; screenshot captions retain their actual capture revisions.

  • Remote CI passed on 342221e73ee590dcbe0c504c75f0a6ae56468d0a, including focused regressions for both settings.

  • Chrome for Testing 153.0.8010.36 reproduced the bug before and passed queueing, steering, and empty-composer submission afterward.

  • Source CLI readback confirmed queue contents after each action. Desktop viewport: 1440×900 at 2×.

  • The requested cumulative Slop Cop and Slim PR passes retained this layer without changes or new findings.

Before: 963171ce1f38032e34bdd41c17a7454815504174 · After: 342221e73ee590dcbe0c504c75f0a6ae56468d0a · Desktop, 1440×900, 2×.

State Before After
Empty composer after Enter, Enter steers Before: message remains queued Open After: queued message sent Open

Merge requested by the user after QA. Merged atomically with the stack as ebf29a865fddf6b5934d24af7c9fcae9dbc2edc0. Post-merge CI passed all 13 jobs.

BB-Thread-ID: thr_k3vhrnr4cw

AGENT GENERATED

@brsbl brsbl changed the title Fix queued-message Enter behavior in steer mode Send queued messages with Enter in steer mode Sep 19, 2026
@brsbl brsbl changed the title Send queued messages with Enter in steer mode Fix shared composer send shortcuts and mobile queue access Sep 20, 2026
@brsbl brsbl changed the title Fix shared composer send shortcuts and mobile queue access Fix queued-message submission when Enter steers Sep 20, 2026
@brsbl
brsbl added this pull request to stack #3972 September 20, 2026 21:37
@brsbl
brsbl force-pushed the bb/update-composer-enter-behavior-thr_k3vhrnr4cw branch from 23fce5b to 342221e Compare September 20, 2026 22:51
@brsbl brsbl changed the title Fix queued-message submission when Enter steers Send queued messages with Enter when Enter steers Sep 20, 2026
@brsbl
brsbl force-pushed the bb/update-composer-enter-behavior-thr_k3vhrnr4cw branch from 342221e to 7ea5925 Compare September 21, 2026 03:27
@brsbl
brsbl merged commit ebf29a8 into main Sep 21, 2026
16 checks passed
@brsbl
brsbl deleted the bb/update-composer-enter-behavior-thr_k3vhrnr4cw branch September 21, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant