Skip to content

Drag sidebar threads into composers to mention them - #3907

Merged
SawyerHood merged 2 commits into
mainfrom
bb/drag-threads-to-compose-thr_s24hfeswxt
Sep 18, 2026
Merged

SawyerHood merged 2 commits into
mainfrom
bb/drag-threads-to-compose-thr_s24hfeswxt

Conversation

@SawyerHood

@SawyerHood SawyerHood commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

Sidebar thread drags only resolved split-pane targets, so dropping a thread onto a compose box could not insert a mention.

What changed

Register editable compose boxes as thread-mention drop targets and prioritize them over split-pane targets. Hovering shows “Mention thread”; dropping inserts the existing mention pill at the pointer position, with the normal serialized thread reference. This works in new-thread and follow-up composers while preserving split-pane drops elsewhere.

Also make the scaffold test task depend on SDK declaration generation, so packing the SDK waits for its bundled types on a clean CI checkout.

How you verified

  • pnpm exec turbo run typecheck --filter=@bb/app passed.
  • pnpm exec turbo run test --filter=@bb/app -- --run src/lib/split-drag/splitDragSession.test.ts src/components/promptbox/PromptBoxInternal.test.tsx passed all 149 tests, including new coverage for mention insertion, drop priority, moving away, and cancellation.
  • In an isolated dev app, dragged a sidebar thread into both new-thread and follow-up composers using real browser input. Verified the highlight, correct mention token, unchanged route, and draft persistence after reload.
  • pnpm exec turbo run test --filter=@bb/templates passed all 47 tests after adding the missing build dependency.
  • User tested and approved the change.

AGENT GENERATED

@SawyerHood
SawyerHood merged commit 8bcbb79 into main Sep 18, 2026
16 checks passed
@SawyerHood
SawyerHood deleted the bb/drag-threads-to-compose-thr_s24hfeswxt branch September 18, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant