Drag sidebar threads into composers to mention them - #3907
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Sidebar thread drags only resolved split-pane targets, so dropping a thread onto a compose box could not insert a mention.
What changed
Register editable compose boxes as thread-mention drop targets and prioritize them over split-pane targets. Hovering shows “Mention thread”; dropping inserts the existing mention pill at the pointer position, with the normal serialized thread reference. This works in new-thread and follow-up composers while preserving split-pane drops elsewhere.
Also make the scaffold test task depend on SDK declaration generation, so packing the SDK waits for its bundled types on a clean CI checkout.
How you verified
pnpm exec turbo run typecheck --filter=@bb/apppassed.pnpm exec turbo run test --filter=@bb/app -- --run src/lib/split-drag/splitDragSession.test.ts src/components/promptbox/PromptBoxInternal.test.tsxpassed all 149 tests, including new coverage for mention insertion, drop priority, moving away, and cancellation.pnpm exec turbo run test --filter=@bb/templatespassed all 47 tests after adding the missing build dependency.