Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Thread recency only reordered threads inside fixed project, section, and machine lists, leaving active work below older lists.
What changed
How you verified
8abf42716.Before: merge base
2c9fdf2dc. Menu after: exact head8abf42716. Captures use the same fixture,/route, light theme, viewport, and 2× density. The new submenu's before image shows the preceding sort menu.Activity-ordering evidence from 91336f5
These ordering captures predate the menu-only revision. Menu evidence above is from the current head.
Slop Cop review and P2 follow-ups
Reviewed
25744d61baef359d73926c51a5dec2f4d7debc47against8d35c2776bc7fd33f41a64e4c6dd7ebd2f021887usinggit diff 8d35c2776..25744d61b. Security and architecture found no issues. Correctness and performance each found one P2. The end-to-end panel accepted the existing exact-build QA evidence. No second review ran.These follow-ups were recorded without expanding this PR. Remaining regression tests cover nested activity, hidden/empty groups, running priority, and sort direction; existing shared tests retain manual and pinned ordering coverage.
BB-Thread-ID: thr_wq5qtf8k3u