Use VBlank interrupt for Unbricked frame timing#188
Closed
goodnamenotbad wants to merge 1 commit into
Closed
Conversation
Contributor
|
Wow, you arrived slightly too late #187 By the way, What are the chances! |
Member
|
Closing this for now, it's a large change and appears to be primarily AI-generated, which we don't have the bandwidth to review thoroughly. If you'd like to resubmit a more focused, human-driven contribution, we're happy to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157.
This updates the Unbricked examples so frame timing/main loops wait on the VBlank interrupt instead of busy-polling
rLY.Notes:
IE_VBLANKand usehaltviaWaitForVBlank.wVBlankDoneflag to ignore serial wakeups while waiting for VBlank.rLY, since those are one-time initialization waits rather than frame timing/main-loop control.Verification:
git diff --checkobjects,functions,input,collision,bricks,bcd,audio,title-screen,serial-link.