fix: harden test infrastructure and iOS device QA#2264
Merged
16francej merged 14 commits intoJul 15, 2026
Merged
Conversation
…-infra-isolated-review
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
16francej
marked this pull request as ready for review
July 15, 2026 01:33
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
This PR combines a set of small test-infrastructure and iPhone-testing fixes that were reviewed together.
In simple terms, it:
--limitvalues instead of silently doing something surprising;carefulmode catch disguised destructive delete commands;Original PRs covered
This PR replaces or completes the useful parts of:
It intentionally does not include workflow-policy changes, model overlays, version bumps, changelog edits, promotional copy, or unrelated cleanup.
Testing
bun run build: passed.git diff --check: passed.bun test: exited successfully and all wave-related suites passed. Its output reported five failures in a newly upstreamed gbrain install test caused by that test's Bun PATH fixture; this branch changes neither implicated file.build-imagecheck is red because fork PR credentials are not allowed to pushghcr.io/garrytan/gstack/ci; the image itself built successfully, then the registry rejected the push. Windows tests, generated-doc freshness, and workflow lint passed.Post-review fixes
After these fixes: 190 focused tests passed with 665 assertions, the repository-wide suite exited successfully, the build passed, and the physical iPhone suite passed 4/4 with 86 assertions.
Remaining limits
Review result
MERGE-WITH-CHANGES: merge this reconstructed branch, not the old combined wave branch.
Closes #553
Closes #789
Closes #1684
Closes #1688
Closes #1762
Closes #1766
Closes #1896
Closes #1919
Closes #1936
Closes #2025
Closes #2040