Fix Map assertions with babel transform-runtime#308
Open
landeqiming666 wants to merge 1 commit into
Open
Conversation
10 tasks
Author
|
Hi, a brief follow-up on this PR. It remains clean and mergeable. The patch targets the class-property Map case under babel transform-runtime and includes end-to-end transform fixtures. Happy to adjust the transform scope or tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mapcan be rewritten consistently bybabel-plugin-transform-runtimeMapinstances created outside the current realm, which avoids aninstanceofmismatch when the runtime constructor differsThis keeps the conversion change scoped to class-property decorators and covers both the generated reference and the runtime predicate path.
Fixes #177
Validation
yarn --cwd packages/babel-plugin-flow-runtime buildyarn --cwd packages/babel-plugin-flow-runtime test(240 passing)yarn --cwd packages/flow-runtime test(169 passing)git diff --checkIssueHunt Summary
Referenced issues
This pull request has been submitted to: