Skip to content

perf(Core): tweak tryFindTextOfRange #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Numpsy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(Core): tweak tryFindTextOfRange #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/FSharpLint.Core/Framework/Utilities.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,15 @@ module ExpressionUtilities =

/// Tries to find the source code within a given range.
let tryFindTextOfRange (range:Range) (text:string) =
let maybeStartIndex = findPos range.Start text
let maybeEndIndex = findPos range.End text

match (maybeStartIndex, maybeEndIndex) with
| Some(startIndex), Some(endIndex) ->
text.Substring(startIndex, endIndex - startIndex) |> Some
| _ -> None
findLineStart text range.Start.Line 1 0
|> Option.bind (fun startLineOffset ->

@webwarrior-ws webwarrior-ws Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer pattern matching to Option.bind and Option.map, but that's just stylistic choice.

@Numpsy Numpsy Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could change it to something like

        match findLineStart text range.Start.Line 1 0 with
        | Some startLineOffset ->
            match findLineStart text range.End.Line range.Start.Line startLineOffset with
            | Some endLineOffset ->
                let startIndex = startLineOffset + range.Start.Column
                let endIndex = endLineOffset + range.End.Column
                text.Substring(startIndex, endIndex - startIndex) |> Some
            | None -> None
        | None -> None

if you'd prefer that.

findLineStart text range.End.Line range.Start.Line startLineOffset
|> Option.map (fun endLineOffset ->
let startIndex = startLineOffset + range.Start.Column
let endIndex = endLineOffset + range.End.Column
text.Substring(startIndex, endIndex - startIndex)
)
)

let getLeadingSpaces (range:Range) (text:string) =
let range = Range.mkRange String.Empty (Position.mkPos range.StartLine 0) range.End
Expand Down
Loading