fix: stop stdStorage access recording - #906
Merged
Merged
Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
August 26, 2026 02:53
DaniPopes
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
stdStorage.findstarts storage-access recording but leaves it enabled after reading the results. This keeps Foundry on the inspector slow path for the remainder of any test that usesstdstoreor ERC20deal. This addresses the forge-std side of foundry-rs/foundry#16376.Solution
Call
vm.stopRecord()immediately after retrieving the recorded accesses, and add a regression test proving subsequent storage reads are not recorded.Testing
forge fmt --checkforge test(207 passed)Prompted by: @DaniPopes