Skip to content

refactor(lana): use URI-safe file access - #2

Merged
peternhale merged 1 commit into
mainfrom
ph/W-23939830-uri
Aug 21, 2026
Merged

refactor(lana): use URI-safe file access#2
peternhale merged 1 commit into
mainfrom
ph/W-23939830-uri

Conversation

@peternhale

@peternhale peternhale commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

PR overview

Stack 2 of 4. Depends on #1. Makes log and workspace handling URI-native so Lana can operate against local and virtual filesystems.

Changes made

  • Replace filesystem paths with VS Code Uri values or serialized URI strings.
  • Route reads, writes, existence checks, caching, and navigation through URI-safe services.
  • Support file, memfs, vscode-vfs, and other virtual workspace schemes.
  • Update log analysis, language detection, providers, source lookup, and workspace selection.
  • Update URI mocks and affected unit tests.

Type of change

  • Refactor

Related issues

related W-23939830

Validation

  • pnpm typecheck
  • Seven focused unit suites: 98 tests

@peternhale
peternhale requested a review from mshanemc August 21, 2026 13:32
@peternhale
peternhale marked this pull request as ready for review August 21, 2026 13:32
Base automatically changed from ph/W-23939830-services to main August 21, 2026 18:42
@peternhale
peternhale merged commit fba46d9 into main Aug 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants