Fix nightly CI: ^26 jobs silently dropped due to missing macos runner label - #4162
Merged
Merged
Conversation
… label
When ^27 was added to the matrix, the ^26 include was left without a
macos: entry. The nightly passes macos: ${{ matrix.macos }} to the
reusable workflow; for ^26 this evaluates to "", overriding the
macos-latest default and producing runs-on: "" — jobs never queue.
Adding macos: macos-latest to the ^26 include restores the intended
behavior: ^26 tests run on the latest macOS runner (which has Xcode 26).
|
||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4162 +/- ##
==========================================
- Coverage 71.48% 67.34% -4.14%
==========================================
Files 254 254
Lines 22868 22901 +33
==========================================
- Hits 16347 15423 -924
- Misses 6521 7478 +957
🚀 New features to boost your workflow:
|
|
||||||||||||||||
brandonpage
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since
W-24027227: Add iOS 27 to nightly CI(#4156), the^26test and sample-build jobs have been silently absent from every nightly run (e.g. 33235375451).Root cause: The
^26include entry was left without amacos:field. The nightly passesmacos: ${{ matrix.macos }}to the reusable workflow; for^26combinationsmatrix.macosevaluates to"", which overrides the reusable workflow'sdefault: macos-latest. The result isruns-on: ""— GitHub Actions silently drops jobs with an empty runner label instead of falling back to the default.Fix
Add
macos: macos-latestto the^26include in both theios-nightlyandnative-samples-nightlyjobs, matching the explicitmacos:already set for^27(xcode-27) and^18(macos-15).Test plan
^26jobs appear alongside^27and^18^26jobs complete successfully (they ran fine before W-24027227: Add iOS 27 to nightly CI #4156)