[iOS] Capture ui_sid from DPoP token response and use it in mainSid - #4154
Merged
Conversation
…inSid Adds uiSid to SFOAuthCredentials: captured when tokenType is "dpop", stored encrypted in keychain under a new service key. Updates mainSid to return uiSid first, falling back to the existing jwt/access-token logic.
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4154 +/- ##
==========================================
- Coverage 67.46% 67.44% -0.02%
==========================================
Files 254 254
Lines 22859 22868 +9
==========================================
+ Hits 15422 15424 +2
- Misses 7437 7444 +7
🚀 New features to boost your workflow:
|
|
||||||||||||||
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uiSidproperty toSFOAuthCredentials(public readonly in.h, readwrite in+Internal.h)uiSidto the keychain inSFOAuthKeychainCredentialsundercom.salesforce.mobilesdk.oauth.uiSidupdateCredentials:, readsui_sidfrom the token endpoint response, guarded ontokenType == "dpop"mainSidgetter: returnsuiSidif present, otherwise falls back to existing logic (parentSidfor jwt,accessTokenotherwise)SFOAuthCredentialsTests.mDependencies
This PR depends on (already merged):
Related PRs (same feature):
Tracking