[Android] AuthFlowTester: display mainSid/uiSid and assert them in tests - #3020
Merged
Conversation
- UserCredentialsView: add MAIN_SID and UI_SID constants and rows in Domains and SIDs section; include in JSON export - AuthFlowTesterPageObject: add validateSIDs private method; assert mainSid always non-empty, uiSid non-empty on DPoP, and mainSid == uiSid (DPoP) / parentSid (JWT hybrid) / accessToken (opaque); call from validateOAuthValues
getSensitiveValue returns the literal string "(empty)" when a field has no value, not an empty string. Without this fix the uiSid branch fires incorrectly for non-DPoP logins, causing a spurious assertion failure.
Add domain+SID checks (content/lightning/VF, gated on scope and hybrid flow) and parentSid presence check (gated on JWT+hybrid) to match the full set of assertions in the iOS assertSIDs function. Also expose the six domain/SID label constants so the page object can reference them, and thread useHybridAuthToken through validateOAuthValues from loginAndValidate.
3 tasks
brandonpage
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAIN_SIDandUI_SIDconstants; adds rows for mainSid and uiSid in the Domains and SIDs section; includes them in the JSON export.validateSIDs(isDpop, accessToken)method that asserts:mainSidis always non-emptyuiSidis non-empty when DPoP is activemainSid == uiSid(DPoP),mainSid == parentSid(JWT hybrid), ormainSid == accessToken(opaque Bearer)validateOAuthValuesDependencies
Builds on top of merged PRs:
Related iOS PR: forcedotcom/SalesforceMobileSDK-iOS#4157
Test plan
testECAJwtDPoP_ViaLoginPoolServer— verifies uiSid non-empty and mainSid == uiSidtestECAJwt_DefaultScopes— verifies mainSid == parentSidtestCAOpaque_DefaultScopes— verifies mainSid == accessToken