feat(create-ideal-cms): gate premium plugins behind a private-registry token - #132
Merged
Merged
Conversation
…y token apps/cms ships @fr-private/payload-plugin-visual-editing, which 404s for anyone scaffolding without FocusReactive's private-registry access. Add an optional prompt for a private-plugin token: without one, strip the plugin's dependency and its 5 wiring points from the scaffold output; with one, write a .npmrc that reads NPM_TOKEN from the environment (never persisted to disk, so initGit can't commit the secret) and keep the plugin wired.
dogfrogfog
requested review from
ChiefCreator and
SearheiParkhamchuk
as code owners
September 7, 2026 10:10
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🎉 This PR is included in version 0.11.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/cmsdepends on@fr-private/payload-plugin-visual-editing, a FocusReactive-only premium plugin. Anyone scaffolding vianpx create-ideal-cmswithout private-registry access hit a404onbun installfor that scope.lib/plugins/index.tsregistration, thelayout.tsx<VisualEditing.Provider>wrapper —LivePreviewListenerstays for draft-mode live preview,RichText/prepareMediaPropshelper calls, and the adminimportMap.jsentry) so the scaffolded project installs and type-checks clean with no private-scope dependency at all..npmrcreferencing${NPM_TOKEN}(never the literal secret, sogit init && git add .in the scaffold can't commit it into the new project's history) and installs withNPM_TOKENset only as an env var for that install run.apps/cmsin this monorepo is untouched either way — the demo project keeps the plugin.packages/create-ideal-cms/README.md.Test plan
apps/cms: dependency + all 5 touch points removed, zero leftover@fr-privatereferences,tsgo --noEmitpasses with 0 errors.npmrcwritten with${NPM_TOKEN}interpolation (no literal secret on disk),apps/cmsleft fully intactbun run build,bunx ultracite check, and a manualtsgo --noEmitonpackages/create-ideal-cmsall passbunx turbo run check-typespasses (5/5 tasks)