Set up fmagent fork: pin v1.3.0 + #1211 fix (upstream PR #1223)#1
Closed
Dshuishui wants to merge 3 commits into
Closed
Set up fmagent fork: pin v1.3.0 + #1211 fix (upstream PR #1223)#1Dshuishui wants to merge 3 commits into
Dshuishui wants to merge 3 commits into
Conversation
…ef return types (colbymchenry#1211) tree-sitter-c can't reconcile an unknown macro token before a typedef'd return type — `SEC_ATTR UINT32 LostName(VOID)` misparsed the function name as `(VOID)` instead of `LostName`. This affected all C projects using section/placement macros (OpenHarmony LiteOS-M, embedded firmware, etc.). Two additions to preParseCSource: 1. blankCLeadingMacros — blanks arbitrary ALL_CAPS tokens sitting before a known C return type at line start (handles project-specific macros like SEC_ATTR, LITE_OS_SEC_TEXT_INIT that no curated list can cover). 2. Wire in blankCppInlineMacros — catches known inline-specifier macros already curated for C++ (SQLITE_API, WINAPI, G_INLINE_FUNC, etc.) that are equally common in C codebases. Closes colbymchenry#1211
…fix / upstream PR colbymchenry#1223)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializes this maintenance fork.
What
attributes before a typedef'd return type, so functions like
LITE_OS_SEC_TEXT_INIT UINT32 LOS_KernelInit(VOID)are indexed under theirreal name instead of the parameter list
(VOID). (src/extraction/languages/c-cpp.ts+ test)1.3.0-fmagent.1(package.json+package-lock.json),so
codegraph --versionidentifies a fork build.Base / policy
mainis pinned (reset) to upstream v1.3.0; these 3 commits sit on top.1.3.0-fmagent.1patch onto the identicalv1.3.0 base — no §4-K silent-break risk.
Upstream colbymchenry#1211 is still open and unreleased (latest v1.4.1 still has the bug), so
this fork is required as a stopgap for FM-Agent.