Conversation
Karthik-Chowdary
left a comment
Karthik-Chowdary
left a comment
There was a problem hiding this comment.
I reviewed the migration predicate and condition invariants. The current static-object test can accept pre-migration or stale Ready conditions and skip the migration that establishes NoIndex; I left details inline.
|
@Karthik-Chowdary Thanks for the review. Hardened the static-object path so tests no longer accept pre-migration or stale Ready ( Pushed in 4368179. |
4368179 to
1881e36
Compare
OCI HelmRepositories finished migration with an empty status, so kubectl Ready/Status columns stayed blank. Set Ready=True with reason NoIndex after migrating to a static object, and treat that state as fully migrated so a later reconcile does not wipe it. Assisted-by: Cursor Grok 4.6/cursor-grok-4.6-high-fast Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Rosh Ramadass <roshpr@gmail.com>
Stale Ready=True with reason Succeeded (or empty) was treated as a completed OCI migration, so the one-shot reconcile that sets NoIndex could be skipped. Require Ready=True with reason NoIndex before skipping migration, and assert that in predicate and reconciler tests. Assisted-by: Cursor Grok 4.6/cursor-grok-4.6-high-fast Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Rosh Ramadass <roshpr@gmail.com>
1881e36 to
46d2ca8
Compare
|
Friendly bump for maintainer review when you have a moment. This PR is up to date with @dipti-pai would you be able to take a look? Happy to follow up on any further review comments. |
|
The issue was closed by the author as they understood the controller is working as designed. |
3 participants
Fixes #2135
Developed with Cursor assistance.
OCI
HelmRepositoryobjects currently finish migration with an empty status, so the Ready/Status printer columns stay blank. After migrating to a static object, setReady=Truewith reasonNoIndex(no index Artifact; charts are resolved on demand). Treat that Ready state as fully migrated so a later reconcile does not wipe it.Empty status is no longer treated as already migrated, so existing
status: {}objects get the condition on controller restart.Test coverage
type: ociHelmRepository reports Ready without an index artifactDocumentation
Update
docs/spec/v1/helmrepositories.mdso OCI examples and status docs describe the Ready condition instead of a blank status.