Allow KEDA minReplicas to be zero - #1970
Open
KundanDhage wants to merge 1 commit into
Open
KundanDhage wants to merge 1 commit into
KundanDhage wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Kundan Dhage <kundan@acsgaming.com>
KundanDhage
force-pushed
the
kundandhage-allow-keda-zero-replicas
branch
from
September 9, 2026 15:12
96723e7 to
ec39ff4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flagger's Canary CRD rejects autoscalerRef.primaryScalerReplicas.minReplicas: 0, even when the referenced autoscaler is a KEDA ScaledObject, which supports scale-to-zero (minReplicaCount: 0). This blocks event-driven / scale-to-zero setups.
Change
Updated the CEL validation rule so minReplicas >= 1 is still enforced for HorizontalPodAutoscaler, but minReplicas: 0 is now allowed for ScaledObject. Regenerated CRD manifests via make manifests — no hand-edited YAML.
Testing
go test ./pkg/apis/flagger/v1beta1/...
Covers: minReplicas: 0 + ScaledObject (accepted), minReplicas: 0 + HorizontalPodAutoscaler (still rejected), minReplicas: 1 + either kind (regression check).
Open question
Are there other places assuming
minReplicasis never zero (reconciler, scaling logic)? Happy to extend if so.Closes #1869