Repository navigation
fix(server): advertise an https resource behind TLS-terminating load balancers - #101
Merged
Merged
Conversation
…balancers The protected resource metadata and the 401 challenge took their scheme from X-Forwarded-Proto, falling back to http. A load balancer that terminates TLS without setting that header made the server advertise http://<host>/mcp, which does not match the https URL clients connect to, so they reject the metadata and OAuth never starts. Without the header, only loopback hosts are plain http now; any other host is https, the only scheme MCP clients accept for a non-loopback authorization target. X-Forwarded-Proto is honored only for http or https.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protected resource metadata and the 401 challenge took their scheme from
X-Forwarded-Proto, defaulting to http. Behind a load balancer that terminates TLS without setting that header, the server advertisedhttp://<host>/mcp, which does not match the https URL clients connect to, so OAuth discovery fails.X-Forwarded-Protois honored only when it ishttporhttps.Tests cover: no forwarded proto, loopback, unknown proto, forwarded http, proxy with comma-separated proto.
make checkpasses.