Skip to content

Added config dir support #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgarciacardenas merged 2 commits into from
Jun 18, 2026
Merged

Added config dir support #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14320c
Added config dir support
Jun 4, 2026
13b96a6
Added missing pre-commit
fgarciacardenas Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions fixposition_driver_ros1/launch/dev.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
<launch>
<arg name="node_name" default="fixposition_driver_ros1" doc="Node name"/>
<arg name="config" default="config.yaml" doc="Configuration file to use"/>
<arg name="launcher" default="" doc="Launch node via this (node launch-prefix)"/>
<arg name="node_name" default="fixposition_driver_ros1" doc="Node name"/>
<arg name="config" default="config.yaml" doc="Configuration YAML filename"/>
<arg name="config_dir" default="$(find fixposition_driver_ros1)/launch" doc="Directory containing the configuration file"/>
<arg name="launcher" default="" doc="Launch node via this (node launch-prefix)"/>

<env name="ROSCONSOLE_CONFIG_FILE" value="$(find fixposition_driver_ros1)/launch/rosconsole_dev.conf"/>
<node name="$(arg node_name)" pkg="fixposition_driver_ros1" type="fixposition_driver_ros1" output="screen" respawn="false" launch-prefix="$(arg launcher)">
<rosparam command="load" file="$(find fixposition_driver_ros1)/launch/$(arg config)"/>

<node name="$(arg node_name)"
pkg="fixposition_driver_ros1"
type="fixposition_driver_ros1"
output="screen"
respawn="false"
launch-prefix="$(arg launcher)">
<rosparam command="load" file="$(arg config_dir)/$(arg config)"/>
</node>
</launch>
19 changes: 14 additions & 5 deletions fixposition_driver_ros1/launch/node.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
<launch>
<arg name="node_name" default="fixposition_driver_ros1" doc="Node name"/>
<arg name="config" default="config.yaml" doc="Configuration file to use"/>
<arg name="launcher" default="" doc="Launch node via this (node launch-prefix)"/>
<arg name="node_name" default="fixposition_driver_ros1" doc="Node name"/>
<arg name="config" default="config.yaml" doc="Configuration YAML filename"/>
<arg name="config_dir" default="$(find fixposition_driver_ros1)/launch" doc="Directory containing the configuration file"/>
<arg name="launcher" default="" doc="Launch node via this (node launch-prefix)"/>

<env name="ROSCONSOLE_CONFIG_FILE" value="$(find fixposition_driver_ros1)/launch/rosconsole.conf"/>
<node name="$(arg node_name)" pkg="fixposition_driver_ros1" type="fixposition_driver_ros1" output="screen" respawn="true" respawn_delay="5" launch-prefix="$(arg launcher)">
<rosparam command="load" file="$(find fixposition_driver_ros1)/launch/$(arg config)"/>

<node name="$(arg node_name)"
pkg="fixposition_driver_ros1"
type="fixposition_driver_ros1"
output="screen"
respawn="true"
respawn_delay="5"
launch-prefix="$(arg launcher)">
<rosparam command="load" file="$(arg config_dir)/$(arg config)"/>
</node>
</launch>
10 changes: 6 additions & 4 deletions fixposition_driver_ros2/launch/dev.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<!-- https://design.ros2.org/articles/roslaunch_xml.html -->
<launch>
<arg name="node_name" default="fixposition_driver_ros2" description="Node name"/> <!-- -->
<arg name="config" default="config.yaml" description="Configuration file to use"/>
<arg name="launcher" default="" description="Launch node via this (node launch-prefix)"/>
<arg name="node_name" default="fixposition_driver_ros2" description="Node name"/>
<arg name="config" default="config.yaml" description="Configuration YAML filename"/>
<arg name="config_dir" default="$(find-pkg-share fixposition_driver_ros2)/launch" description="Directory containing the configuration file"/>
<arg name="launcher" default="" description="Launch node via this (node launch-prefix)"/>

<node name="$(var node_name)" pkg="fixposition_driver_ros2" exec="fixposition_driver_ros2_exec"
output="screen" respawn="true" respawn_delay="5" launch-prefix="$(var launcher)"
ros_args="--log-level $(var node_name):=debug">
<param from="$(find-pkg-share fixposition_driver_ros2)/launch/$(var config)"/>
<param from="$(var config_dir)/$(var config)"/>
<param name="some_numeric_param" value="100.2"/>
</node>
</launch>
10 changes: 6 additions & 4 deletions fixposition_driver_ros2/launch/node.launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<!-- https://design.ros2.org/articles/roslaunch_xml.html -->
<launch>
<arg name="node_name" default="fixposition_driver_ros2" description="Node name"/> <!-- -->
<arg name="config" default="config.yaml" description="Configuration file to use"/>
<arg name="launcher" default="" description="Launch node via this (node launch-prefix)"/>
<arg name="node_name" default="fixposition_driver_ros2" description="Node name"/>
<arg name="config" default="config.yaml" description="Configuration YAML filename"/>
<arg name="config_dir" default="$(find-pkg-share fixposition_driver_ros2)/launch" description="Directory containing the configuration file"/>
<arg name="launcher" default="" description="Launch node via this (node launch-prefix)"/>

<node name="$(var node_name)" pkg="fixposition_driver_ros2" exec="fixposition_driver_ros2_exec"
output="screen" respawn="true" respawn_delay="5" launch-prefix="$(var launcher)"
ros_args="--log-level $(var node_name):=info">
<param from="$(find-pkg-share fixposition_driver_ros2)/launch/$(var config)"/>
<param from="$(var config_dir)/$(var config)"/>
<param name="some_numeric_param" value="100.2"/>
</node>
</launch>
Loading