deps: specify explicit dependency features - #6175
Open
ShadowCurse wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6175 +/- ##
==========================================
+ Coverage 83.01% 83.03% +0.01%
==========================================
Files 277 277
Lines 30933 30928 -5
==========================================
Hits 25680 25680
+ Misses 5253 5248 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Go over all dependencies we have and explicitly select only features we actually need. This reduces the number of transitive dependencies we pull and makes it harder to accidentally introduce new ones. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
explicit_dep_features
branch
from
September 2, 2026 15:03
bfd39b7 to
e189a3b
Compare
ShadowCurse
marked this pull request as ready for review
September 2, 2026 15:42
ShadowCurse
added
the
Status: Awaiting review
zulinx86
approved these changes
Sep 3, 2026
zulinx86
left a comment
zulinx86
left a comment
Contributor
There was a problem hiding this comment.
We should consider documenting the policy for adding new dependencies in the developer guide. Otherwise, we may need to revisit the same issue periodically in the future. Maybe worth discussing between maintainers.
| assert len(lines) == len(expected_output) | ||
| for line_number, line in enumerate(stderr.splitlines()): | ||
| # Need to strip off timestamps | ||
| print(line) |
Contributor
There was a problem hiding this comment.
Is this a print you used for debugging and forgot to remove, or is it intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Go over all dependencies we have and explicitly select only features we actually need. This reduces the number of transitive dependencies we pull and makes it harder to accidentally introduce new ones.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.