Skip to content

Auto-update dependencies.#2789

Open
dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener
Open

Auto-update dependencies.#2789
dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot
Copy link
Copy Markdown
Collaborator

@dpebot dpebot commented May 12, 2026

Brought to you by your friendly Repository Gardener.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gradle wrapper version from 9.5.0 to 9.5.1 across multiple modules. The reviewer suggested adding the networkTimeout and validateDistributionUrl properties to the module-level wrapper configurations to ensure consistency with the root wrapper and improve build reliability and security.

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The module-level Gradle wrappers are missing the networkTimeout and validateDistributionUrl properties that are present in the root gradle/wrapper/gradle-wrapper.properties. For consistency and improved build reliability and security, consider adding these properties to all module-level wrappers in this project.

distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant