Skip to content

feature: add support for constant values#1835

Open
robertadkins wants to merge 1 commit into
ferdikoomen:mainfrom
robertadkins:add-const-support
Open

feature: add support for constant values#1835
robertadkins wants to merge 1 commit into
ferdikoomen:mainfrom
robertadkins:add-const-support

Conversation

@robertadkins

Copy link
Copy Markdown

Closes #1834

See the issue above for a description of a usecase where support for the const keyword is useful. Updated the snapshot tests to verify correct output.

@robertadkins robertadkins marked this pull request as ready for review October 14, 2023 00:35
@robertadkins

Copy link
Copy Markdown
Author

Since const was added in OpenAPI v3.1 (see discussion in #1834), updating this PR to only modify the v3 parsing and tests.

@mrlubos

mrlubos commented Jan 28, 2024

Copy link
Copy Markdown
Collaborator

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

@kovalewvladimir

Copy link
Copy Markdown

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

Thank you. It really works in the fork.

@mrlubos

mrlubos commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

@kovalewvladimir are there any other issues you're running into with this package?

@lausek

lausek commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@ferdikoomen Can we get this merged please? This is such a small PR and as far as I understand it, it would enable discriminated type unions.

@mrlubos

mrlubos commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@lausek This package has been unmaintained for years so I guess the answer is a no. What's stopping you from using @hey-api?

@lausek

lausek commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Yet it isn't archived and the last commit was two weeks ago.

I don't want hey-api because 1) it is not compatible at all with the current state of the generated client and 2) I don't want generated code in my repo from which I only use 50% (throwOnError)

I just want a simple generated typescript client with discriminated type unions and I think that is not too much to ask for. 🥲 But yea, fork it is then.

@ferdikoomen

Copy link
Copy Markdown
Owner

Hi @lausek, @mrlubos is right, this repo is unmaintained. You really should switch to hey-api :-) I do occasionally commit a dependency/security update, but that is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for const keyword

5 participants