add missing_only=True to all imputers to use in combination with variables=None - #974
add missing_only=True to all imputers to use in combination with variables=None#974ojassharma7 wants to merge 2 commits into
Conversation
The imputers import feature_engine._docstrings.init_parameters.imputers, but the new file was left untracked so CircleCI failed on import. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @ojassharma7 I am making a full migration from pandas to narwahls to support polars and pyarrow as well. So before we expand the functionality of the transformers, I need to complete that migration first. I'll keep this one on hold for now. I'd be happy to have your support on issues related to that migration. You'll find it in #965. We need to update each module to support narwahls instead of the current pandas logic in the fit transform functionality. 1 PR per module. Before choosing what to work on, leave a comment on the main PR, or check that no other PR is open already for that module, not to duplicate work :) |
|
Hi @solegalli — thanks for the clear update, that makes sense. Happy to help with the narwhals migration in #965. I'll check which modules are already claimed / covered there and leave a comment before starting, then open 1 PR for a single module. |
2 participants
Fixes #388.
What changed
feature_engine/imputation/arbitrary_number.pyfeature_engine/imputation/base_imputer.pyfeature_engine/imputation/categorical.pyfeature_engine/imputation/end_tail.pyfeature_engine/imputation/mean_median.pyfeature_engine/imputation/random_sample.pytests/test_imputation/test_arbitrary_number_imputer.pytests/test_imputation/test_categorical_imputer.pytests/test_imputation/test_end_tail_imputer.pytests/test_imputation/test_mean_median_imputer.pytests/test_imputation/test_random_sample_imputer.pyVerification
The project's own test suite was run before and after this change; it introduces no new test failures or lint violations.