IIRR-38: Collapse Rejected table by default, move to the bottom#96
Open
arielj wants to merge 1 commit into
Open
IIRR-38: Collapse Rejected table by default, move to the bottom#96arielj wants to merge 1 commit into
arielj wants to merge 1 commit into
Conversation
arielj
commented
Jun 1, 2026
|
|
||
| .rejected_table { | ||
| summary { | ||
| display: list-item; |
Contributor
Author
There was a problem hiding this comment.
this is the original display value for the summary elements, the styleguide is overriding it and the little arrow gets lost without this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
The motivation for these 2 changes is that the Rejected Puzzles table is not that useful and it's in the middle of the other useful tables.
As that table grows it makes it longer to get to the archived puzzles table which is more relevant from clonning.
I didn't really add tests for this because it feels like testing implementation, collapsing/expanding is just native
<details>tag default behavior.QA:
Scroll to the bottom of the page, you'll see the element to expand/collapse the table.