Skip to content

feat(logo): add deepin_small ASCII logo#2350

Open
multjeux wants to merge 1 commit into
fastfetch-cli:devfrom
multjeux:dev
Open

feat(logo): add deepin_small ASCII logo#2350
multjeux wants to merge 1 commit into
fastfetch-cli:devfrom
multjeux:dev

Conversation

@multjeux
Copy link
Copy Markdown

@multjeux multjeux commented May 28, 2026

Summary

Related issue (required for new logos for new distros)

Closes #

Changes

Screenshots

Checklist

  • I have tested my changes locally.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR successfully implements the 'deepin_small' ASCII logo; however, it does not currently comply with the project's contribution guidelines.

Specifically, the PR description is empty, and the mandatory 'Related issue' link (Closes #) is missing. The project guidelines explicitly state that new logos must be linked to an existing issue for acceptance. Furthermore, no screenshots were provided to verify the visual rendering of the 3-line ASCII art.

While the code implementation is straightforward, these administrative gaps must be addressed before merging.

About this PR

  • Populate the 'Related issue' field (e.g., Closes #XX). Project guidelines require new logos to be linked to an existing issue.
  • Please provide a PR description summarizing the changes and including screenshots of the rendered ASCII logo.

Test suggestions

  • Validate that the 'Deepin_small' name correctly maps to the ASCII data in the logo selection logic.
  • Verify the visual rendering of the 3-line ASCII art in the terminal.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate that the 'Deepin_small' name correctly maps to the ASCII data in the logo selection logic.
2. Verify the visual rendering of the 3-line ASCII art in the terminal.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@fastfetch-cli fastfetch-cli deleted a comment from codacy-production Bot May 28, 2026
@CarterLi
Copy link
Copy Markdown
Member

What original image logo is this small ASCII logo based on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants